WordPress.org

Make WordPress Core

Opened 21 months ago

Last modified 6 weeks ago

#43281 new enhancement

Capitalize "Set featured image" media button on Media Modal

Reported by: monikarao Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: Media Keywords: has-patch 2nd-opinion needs-design-feedback
Focuses: ui Cc:
PR Number:

Description

All the button on WordPress are in capitalize form except this "Set featured image" button so there should be consistency on all button.

Attachments (3)

capitalize-button.png (25.9 KB) - added by monikarao 21 months ago.
Button in capitalize form
no-capitalize-button.png (27.3 KB) - added by monikarao 21 months ago.
Not capitalize
43281.diff (1.1 KB) - added by monikarao 21 months ago.

Download all attachments as: .zip

Change History (11)

@monikarao
21 months ago

Button in capitalize form

@monikarao
21 months ago

Not capitalize

@monikarao
21 months ago

#1 @chetan200891
21 months ago

  • Keywords has-patch added

#2 @SergeyBiryukov
21 months ago

  • Milestone changed from Awaiting Review to 5.0

#3 @SergeyBiryukov
21 months ago

  • Keywords 2nd-opinion added

There's a number of other non-capitalized primary buttons in media modal:

  • Insert into post
  • Create a new gallery
  • Create a new playlist
  • Create a new video playlist

As well as in other parts of WordPress:

  • I understand
  • Restore image
  • Go back
  • Take over
  • Back to theme sources

Most of primary buttons are indeed capitalized, but I don't think it's necessary to capitalize them all. Thoughts?

#4 @Presskopp
21 months ago

A thought (not A Thought):

Set Featured Image - because "Featured Image" is a terminus technicus inside WP, but
Add new category, because it's generally spoken.

Keeping this logic most of them would not need to be capitalized.

#5 @johnbillion
12 months ago

  • Milestone changed from 5.0 to 5.1
  • Version trunk deleted

#6 @pento
10 months ago

  • Keywords needs-design added
  • Milestone changed from 5.1 to Future Release

#7 @karmatosed
5 months ago

  • Keywords needs-design-feedback added; needs-design removed

I think I am right in saying this needs design feedback, not an actual design. I am going to add that keyword.

#8 @afercia
6 weeks ago

Relevant to this ticket: the ongoing discussion on the Gutenberg repository, with the proposal to shift to sentence case where possible. See https://github.com/WordPress/gutenberg/issues/16764#issuecomment-522799402

Note: See TracTickets for help on using tickets.