WordPress.org

Make WordPress Core

Opened 4 years ago

Last modified 5 months ago

#43281 new enhancement

Capitalize "Set featured image" media button on Media Modal

Reported by: monikarao Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: Media Keywords: has-patch 2nd-opinion
Focuses: ui Cc:

Description

All the button on WordPress are in capitalize form except this "Set featured image" button so there should be consistency on all button.

Attachments (3)

capitalize-button.png (25.9 KB) - added by monikarao 4 years ago.
Button in capitalize form
no-capitalize-button.png (27.3 KB) - added by monikarao 4 years ago.
Not capitalize
43281.diff (1.1 KB) - added by monikarao 4 years ago.

Download all attachments as: .zip

Change History (15)

@monikarao
4 years ago

Button in capitalize form

@monikarao
4 years ago

Not capitalize

@monikarao
4 years ago

#1 @chetan200891
4 years ago

  • Keywords has-patch added

#2 @SergeyBiryukov
4 years ago

  • Milestone changed from Awaiting Review to 5.0

#3 @SergeyBiryukov
4 years ago

  • Keywords 2nd-opinion added

There's a number of other non-capitalized primary buttons in media modal:

  • Insert into post
  • Create a new gallery
  • Create a new playlist
  • Create a new video playlist

As well as in other parts of WordPress:

  • I understand
  • Restore image
  • Go back
  • Take over
  • Back to theme sources

Most of primary buttons are indeed capitalized, but I don't think it's necessary to capitalize them all. Thoughts?

#4 @Presskopp
4 years ago

A thought (not A Thought):

Set Featured Image - because "Featured Image" is a terminus technicus inside WP, but
Add new category, because it's generally spoken.

Keeping this logic most of them would not need to be capitalized.

#5 @johnbillion
3 years ago

  • Milestone changed from 5.0 to 5.1
  • Version trunk deleted

#6 @pento
3 years ago

  • Keywords needs-design added
  • Milestone changed from 5.1 to Future Release

#7 @karmatosed
2 years ago

  • Keywords needs-design-feedback added; needs-design removed

I think I am right in saying this needs design feedback, not an actual design. I am going to add that keyword.

#8 @afercia
2 years ago

Relevant to this ticket: the ongoing discussion on the Gutenberg repository, with the proposal to shift to sentence case where possible. See https://github.com/WordPress/gutenberg/issues/16764#issuecomment-522799402

This ticket was mentioned in Slack in #design by estelaris. View the logs.


18 months ago

#10 @joyously
18 months ago

I don't think this needs design. I also don't think it needs changing.

This ticket was mentioned in Slack in #design by chaion07. View the logs.


5 months ago

#12 @paaljoachim
5 months ago

  • Keywords needs-design-feedback removed

I do believe for Gutenberg (Block Editor) it has been decided on using more of a sentence form.
For instance I installed and activated the theme TT1. Then went to the Site Editor. Looked at a few different panels. Border settings, Width settings, etc.

Switching to a post in Gutenberg. Panel says Featured image and there is a text that says "Set featured image" on top of the clickable box to where one sets the image.

Turning on the Classic Editor plugin. Looking at the panels, and if one wanted to have the same text structure as Post Attributes then I would assume that one might also want to adjust the Featured image text to Featured Image. Fix or not to fix.... well that is more difficult to say. I removed "Needs design feedback" as it is not design. It is more of a copy/text than a design related fix.

Note: See TracTickets for help on using tickets.