Make WordPress Core

Opened 6 years ago

Last modified 12 hours ago

#43305 assigned defect (bug)

Accessibility Issue in Arranging the Menu Items: I need a combobox for selecting the parent item and a combobox for selecting the item position

Reported by: javad2000's profile javad2000 Owned by: rcreators's profile rcreators
Milestone: 6.6 Priority: normal
Severity: normal Version:
Component: Menus Keywords: has-patch needs-testing dev-feedback
Focuses: accessibility Cc:

Description

Hello
I shall firstly thank WordPress team for their utmost attention to accessibility standards, which makes WordPress unique among all CMSs. All WordPress
core features are fairly Accessible for me as a blind person who uses screen reader (JAWS), but I always have problems with rearranging the menu items.
Although the menu-items are also very accessible for a blind person and I can re-arrange them very well, this process is very time consuming for me, because;
for example, if I want to send a menu-item from position 16 to position 11, I have to press “Move Up” 5 times. The problem is:
I don’t have any combobox that assigns the mother-item and the item-position. Therefore, I have to adjust the positions by moving each item one by one,
level by level.

Suppose I have a menu with lots of sub-menus and sub-items. Now, I want to add 6 new sub-items to the different menus. Of course, when I add them to the
menu, they are at the end of menu. If I want to bring each item to a certain position near the center of menu, I have to click “Move up” and “Move down”
one by one for many many times over and over. It takes me about 2 hours to rearrange those menu items. I hope I could explain clearly.

Solution:
Beside each menu item, there is a link called “Edit Menu Item”. When I click on the link, a set of options open up: move up, move down, name, etc. I would
like to have two other options as well: mother-item, and position. For example, I adjust the mother-item of “Audio Translation” as “Translation”, and I
adjust its position to “2”, which means subitem number 2 under “Translation”. I hope I could explain clearly what I mean. If I can adjust the menu positions
with comboboxes, I will not have to click “move up” and “move down” many many times.

Attachments (1)

be278c6a27d93abb7dceeeaeb7b15aa0.gif (478.0 KB) - added by audrasjb 6 years ago.
Workaround

Download all attachments as: .zip

Change History (52)

#1 @audrasjb
6 years ago

Hi @javad2000 and many thanks for this ticket,

We are still working on a similar ticket: #40678 - Editing menus in WP admin for blind people. Of course, feel free to comment this other one as well.
I think we can keep both tickets for now because what you offer brings additional elements to the other ticket.

I will work to integrate your solutions on my work on the other ticket.

Cheers,
Jb

Related: #40678

Last edited 6 years ago by audrasjb (previous) (diff)

This ticket was mentioned in Slack in #accessibility by audrasjb. View the logs.


6 years ago

#3 @juliemoynat
6 years ago

Hi,

I think that's a good idea!

@audrasjb, I'm not sure that @javad2000 can see your animated image. :)

In your example, you add a "Move to position:" field with "1", "2", "3", "4" options.
Can we add the total number of items to help a little bit more?

"Move to position:"

  • 1 of 8
  • 2 of 8
  • 3 of 8
  • etc.

@javad2000 also needs another field to define an item as a child. Can we do as we have it for "Pages"?

"Parent:"

  • (no parent)
  • Blog page
  • Sample page
  • W.org
  • Google
  • etc.
Last edited 6 years ago by juliemoynat (previous) (diff)

#4 @afercia
6 years ago

  • Component changed from General to Menus
  • Focuses accessibility added
  • Version 4.9.2 deleted

I will work to integrate your solutions on my work on the other ticket.

I'd recommend to keep things separated :) It's far better to have smaller patches, focused on a single issue, rather than big ones that are difficult to review, test, and they often go stale pretty soon.

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


6 years ago

#6 @afercia
6 years ago

  • Milestone changed from Awaiting Review to Future Release
  • Owner set to audrasjb
  • Status changed from new to assigned

This ticket was mentioned in Slack in #accessibility by rianrietveld. View the logs.


6 years ago

#8 in reply to: ↑ description @javad2000
3 years ago

Hi again
I am still waiting for this feature, but no hope yet after 3 years.

Last edited 3 years ago by javad2000 (previous) (diff)

#9 @javad2000
3 years ago

In addition to those two comboboxes in the Menu Editor Page, we might have those two comboboxes on page/post editor dashboard as well. This helps us assign pages/posts directly to a menu item at a certain position from the page editor dashboard.

#10 @wmalexander
12 months ago

Hello,

This ticket has been dormant for a while - but I wanted to see if there may be any chance of further action related to this issue. I received the following request from one of our users related to this exact issue:


We are familiar with the "Edit Menu" option for each of the menu items, but the
feature is very limited and only allows a couple of movement changes. It would
be great if this menu had an option to move as child to X, or move as parent to
X with much more flexibility.

In the main menu screen, using the NVDA screen reader, I am noticing that
whenever I move menu items around, if I am moving the item up through the menu
structure, as it moves in and out of menus to its destination, other menu items
get included with the original item during the dragging process, which
completely rearranges the entire menu structure.

The only work-around I have found is to not move the item horizontally, but
instead continue moving it vertically through all of the existing menu items
until I reach the new location.

I wonder if perhaps the new WordPress updates address this?


Any room for further discussion and or action related to this issue? Thanks!

#11 @wmalexander
12 months ago

Hello - just hoping this item at least has room for discussion? I tried editing the menu using a screen reader myself and it is, honestly, a terrible experience.

#12 @william.alexander
11 months ago

  • Type changed from feature request to defect (bug)

Hello,

Just poking this ticket again. It looks like the related tickets that are mentioned have been closed, but this issue is certainly unresolved. Having tried myself to edit the menu using a screen reader, it’s clear that the menu editor is close to unusable for a blind user.

#13 @wmalexander
11 months ago

👋 Still hopeful that there is a possibility that this accessibility issue could receive some attention.

#14 @wmalexander
10 months ago

Hello - 👉 just poking to see if this might get rediscussed at some point.

#15 @wmalexander
10 months ago

Just giving this wheel another squeak.

#16 @wmalexander
10 months ago

Hello - really hoping I can update my vision-impaired colleague who reported this issue with something positive about the possibility that this might eventually be fixed.

#17 @william.alexander
9 months ago

@audrasjb do you know if there is any remote plan to address this accessibility issue?

#18 @wmalexander
9 months ago

@afercia forgive me for not knowing the protocol for items like this - if an issue like this one appears to be stalled, is there any way to resubmit or reactivate it? Thank you.

#19 @wmalexander
9 months ago

  • Keywords dev-feedback added

#20 @wmalexander
8 months ago

@joedolson a colleague of mine found your WordPress.org profile and suggested that you might be someone who could possibly provide some information about the likelihood that this issue may someday be addressed. Do you know if this is the kind of accessibility issue that might be on the docket for attention in the foreseeable future? Or, do you know if there might be plans to replace the current menu editor with a new version related to the site editor, which might make addressing this issue an effort that would shortly find itself in the WP trash heap?

In a Yoast blog post about WordPress 6.3 I read:

Of course, a WordPress release isn’t complete without several performance and technical enhancements. Also, as with the last few releases, there was a strong focus on accessibility. Making WordPress more accessible with every new version that’s being released.

Which is great to read, and makes me hopeful that the menu editor accessibility will be improved in the near future, but the fact that this ticket has existed for 5 years and continues to receive no updates of any kind does create some pessimism about this issue specifically. Any news of any kind at all?

This ticket was mentioned in Slack in #accessibility by juliemoynat. View the logs.


8 months ago

#22 @joedolson
8 months ago

  • Owner changed from audrasjb to joedolson
  • Status changed from assigned to accepted

This ticket was mentioned in Slack in #accessibility by wmalexander. View the logs.


8 months ago

#24 @joedolson
8 months ago

  • Keywords needs-patch needs-design added; dev-feedback removed

In the Accessibility bug scrub on 2023/8/18, we agreed that adding a mechanism that allows a user to set the parent & position of a menu item is worth pursuing. @travel_girl will work on some designs mockups for both the classic menu editor and for Gutenberg; this is also a problem in the new menu editor, so we should consider both.

#25 @wmalexander
3 months ago

Hello! It's been several months since this topic has had an update. Just curious if there might be any progress underway? Thanks!

#26 @william.alexander
2 months ago

Hello! I thought I'd check in to see if we can get this ticket moving somehow. Is there something I could do to help? I'm not sure what I could do, but if someone could comment on what the next step towards progress is on this task, I would be glad to try to accomplish that step.

This ticket was mentioned in Slack in #accessibility by rcreators. View the logs.


7 weeks ago

#28 @joedolson
7 weeks ago

  • Milestone changed from Future Release to 6.6
  • Owner changed from joedolson to rcreators
  • Status changed from accepted to assigned

Assigning to @rcreators to develop a patch per conversation in Slack.

This ticket was mentioned in PR #6238 on WordPress/wordpress-develop by @rcreators.


7 weeks ago
#29

  • Keywords has-patch added; needs-patch removed

#30 @rcreators
7 weeks ago

  • Keywords needs-testing dev-feedback added; needs-design removed

Hello @joedolson & @williamalexander,

I have added PR for the initial functional working model. Can you guys try it out in Playground and give me feedback on the same? It's still not completely developed but the base code is I think ready.

Pending points:

  • Changing parent/order by dragging needs to be updated in new controls.
  • Changing order or parent items, sub-items need to move with it.

Let me know if anything else remains as well.

NOTE: It's only applied on WordPress admin->menu area. The customiser menu remains.

#31 @wmalexander
7 weeks ago

@rcreators this is great! Thank you so much! I tested in the playground and as far as I can tell this is very much headed in the hoped for direction. I have shared this with my colleague who initially reported the issue to ask for his feedback, which I will share as soon as he provides it. Thank you so much for taking this on!

#32 @rcreators
6 weeks ago

Hello @wmalexander, Thanks for the feedback. I just updated PR with the new code. From my side, I think almost 99% functionality is done. I need some heavy testing on it if something is broken or not working as intended or if there are any scenarios I missed. If you can do that, that will be great.

Once we have confirmation on it, I can update the same on the customizer area and this will be done.

#33 @wmalexander
6 weeks ago

I will work with my colleague to test this early this week. I did find some problems with my testing which I've shown in the video below - if the user moves an item up or down in the menu order with the arrow key (not the dropdown) the dropdown is not updated. I was even able to make a page unintentionally vanish from the menu. Please see the video here: https://www.loom.com/share/59703597c54b4550bcd11378188442d7?sid=5870805b-2695-4e80-b653-4434f60c3d11.

#34 @rcreators
6 weeks ago

Hello @wmalexander, I was not aware of keyboard events. My bad. I updated the code on PR. So it will update the parent and order field with the keyboard events as well. I am still looking into some code and logic optimisation for that menu item getting removed entirely. Mostly has to do with placing out of the index. Let you know, once done. Apart from that, if you come across any issues, do let me know.

#35 @wmalexander
6 weeks ago

@rcreators - I'm getting an error now when I try to test the PR in playground: "Waiting for GitHub to finish building PR 6238. This might take 15 minutes or more! Retrying in 19..." - Do you know what I might need to do differently to resume testing this? It doesn't seem to go away.

#36 follow-up: @rcreators
6 weeks ago

@wmalexander, It happens sometimes. Wait for a few mins or try after some time, it will work.

#37 in reply to: ↑ 36 @wmalexander
6 weeks ago

Replying to rcreators:

@wmalexander, It happens sometimes. Wait for a few mins or try after some time, it will work.

Still seeing that same behavior today, after retrying multiple times yesterday 🤷

#38 @wmalexander
6 weeks ago

Could anyone else following this thread verify whether or not they are able to test this new functionality successfully in the playground? I've tried for a few days now but get the same error every time: "Waiting for GitHub to finish building PR 6238. This might take 15 minutes or more! Retrying in 19..."

#39 @juliemoynat
6 weeks ago

Hi,
After waiting 2 hours, I can confirm that the playground doesn't work…

#40 @rcreators
6 weeks ago

I will be pushing some more code today for the menu item getting removed. Let's see if it will solve the playground issue.

#41 @rcreators
5 weeks ago

@wmalexander & @juliemoynat Just completed most of the code for Admin Menu area and tested with playground. Works fine. Please try and do let me know.

#42 @wmalexander
5 weeks ago

I remain unable to test this in the playground. I'd like to say that I would just build a local site with this PR merged into WordPress, but I'm not really sure if that's the next best option for me to test this. Is that the next best option for testing this?

#43 @wmalexander
4 weeks ago

@rcreators do you think you could push a code update that might refresh the playground for this code? I still have not been able to test this there. For example:

https://www.loom.com/share/6d6e88029e9a4d75ad0ebb4a3c7050fe?sid=b7d962d5-d70c-4f51-9f39-4b6b3f760bfa

#44 @rcreators
4 weeks ago

This ticket was mentioned in Slack in #accessibility by rcreators. View the logs.


3 weeks ago

This ticket was mentioned in Slack in #accessibility by rcreators. View the logs.


2 weeks ago

@berislav.grgicak commented on PR #6238:


5 days ago
#47

Found it! The branch name starts with _#_ and we didn't encode the name.

@rcreators commented on PR #6238:


5 days ago
#48

@bgrgicak So do I remove the # from the branch name cause I am using it for all the branches according to ticket no. But if that solves the issue. I will update all branch names.

@berislav.grgicak commented on PR #6238:


5 days ago
#49

Wrong place. I wanted to comment on this issue https://github.com/WordPress/wordpress-playground/issues/1260.

@bgrgicak So do I remove the # from the branch name cause I am using it for all the branches according to ticket no. But if that solves the issue. I will update all branch names.

No, this PR should fix it https://github.com/WordPress/wordpress-playground/pull/1275

#50 @rcreators
5 days ago

@wmalexander Finally we solved issue with playground. While working on this issue, we solved another bug somewhere else 🙂.

You can test it now. Works great.

#51 @wmalexander
25 hours ago

Yes it is working now - thanks! I will let my colleague know and reply soon with any updates from his testing.

Note: See TracTickets for help on using tickets.