SimplePie deprecated calls modified

[arena]

Since SimplePie has introduced SimplePie_Registry, some methods calling have been deprecated

​http://simplepie.org/api/class-SimplePie.html

[arena]

fix

[SergeyBiryukov]

Related: #29204

[arena]

Replying to SergeyBiryukov:

Related: #29204

hello, fyi

#43357 new enhancement (simplepie doc says there are deprecated functions)

#29204 reviewing defect (bug) (never had this bug in my ​DashPress plugin) and btw a 4 year old ticket !

regards

[arena]

list of deprecated functions :

​http://simplepie.org/api/deprecated.html

[desrosj]

Hi @arena,

Thanks for reporting this! My apologies it took a while for someone to get around to it.

It appears that the documentation linked above is out of date, but the initial premise of the ticket is still correct.

Updating the SimplePie library is being tackled in #36669, hopefully for 5.5. I am going to wait for that to be completed before making these changes so they can be verified and tested against the latest version in WordPress.

There also should be unit tests to ensure the WordPress specific classes are correctly registered in SimplePie using the new registry. If you are able to write those, that would help move this along.

[arena]

I am using simplepie within wordpress several times a day with my plugin dashpress.
Current version is 4.1, but since 3.9 (hereunder extract of readme.txt)

 3.9            2018/02/19 several improvements
   * new thumbnail search with extended SimplePie Item class
   * changing deprecated calls of SimplePie extended classes 

and here is my code in plugin :

<?php
if ( !class_exists( 'SimplePie', false ) ) require_once( ABSPATH . WPINC . '/class-simplepie.php' );

require_once( ABSPATH . WPINC . '/class-wp-feed-cache.php' );
require_once( ABSPATH . WPINC . '/class-wp-feed-cache-transient.php' );
require_once( ABSPATH . WPINC . '/class-wp-simplepie-file.php' );
require_once( ABSPATH . WPINC . '/class-wp-simplepie-sanitize-kses.php' );

$feed = new SimplePie();

$feed->set_cache_duration( $options['caching'] ?? 43200 );

$feed->registry->register( 'Cache', 'WP_Feed_Cache',     true );
$feed->registry->register( 'File',  'WP_SimplePie_File', true );

// this one is specific to plugin
$feed->registry->register( 'Item', 'DBP_SimplePie_Item', true );

and finally, there is a patch attached to this ticket

Replying to desrosj:

Hi @arena,

Thanks for reporting this! My apologies it took a while for someone to get around to it.

It appears that the documentation linked above is out of date, but the initial premise of the ticket is still correct.

Updating the SimplePie library is being tackled in #36669, hopefully for 5.5. I am going to wait for that to be completed before making these changes so they can be verified and tested against the latest version in WordPress.

There also should be unit tests to ensure the WordPress specific classes are correctly registered in SimplePie using the new registry. If you are able to write those, that would help move this along.

[arena]

@desroj

i digged into the SimplePie doc,
the method described above is not the good one.

Hereattached is a new patch that needs to be tested.

[arena]

new patch 2020-04-26

[arena]

with coding standards !

[arena]

and without a typo in $location (?&lifetime becomes ?lifetime)

[arena]

This one is another way to do it

[arena]

So last patch (#43357-4 2020-04-30.patch) might be the more conventional way to do it

Adding to WP_Feed_Cache :

• setting handler 'wordpress' ($handlers)
• get_handlers() function
• create() function is annonced to be deprecated in 1.3.1 but when removed the code do not work as intended.

Adding to WP_Feed_Cache_Transient :

• implements SimplePie_Cache_Base (required by SimplePie)
• adding a function to parse $location (same as SimplePie/Cache.php)
• $lifetime is a parameter of $location

Changing wp-includes/feed.php

• Only one apply_filters 'wp_feed_cache_transient_lifetime' now
• registering classes the new way
• setting cache_location with defined handler

[arena]

WP_Feed_Cache instead of WP_SimplePie_Cache

[arena]

oops ! WP_Feed_Cache instead of WP_SimplePie_Cache

$feed->registry->register( 'Cache', 'WP_Feed_Cache', true );

(may be we should change that as well !)

[arena]

Duplicate of #50159.

simplepie upgraded in trunk to 1.5.5

closing this ticket and opening a new one with patch