WordPress.org

Make WordPress Core

#43727 closed defect (bug) (fixed)

Update Dashboard: Use high-dpi icon assets

Reported by: dd32 Owned by: peterwilsoncc
Milestone: 5.1 Priority: normal
Severity: normal Version:
Component: Upgrade/Install Keywords: has-patch commit
Focuses: Cc:
PR Number:

Description

On wp-admin/update-core.php the icons used is the first in the following order svg, 1x, 2x.

That order seems a little off, it should instead use icons in the order of svg, 2x, 1x.
Right now if a plugin has a 128px and a 256px icon, it'll always use the 128px version.

Patch attached.

Attachments (1)

43727.diff (1.8 KB) - added by dd32 19 months ago.

Download all attachments as: .zip

Change History (7)

@dd32
19 months ago

#1 @peterwilsoncc
19 months ago

  • Keywords commit added

Fix confirmed against an old version of WP Super Cache.

#2 @peterwilsoncc
19 months ago

  • Owner set to peterwilsoncc
  • Resolution set to fixed
  • Status changed from new to closed

In 42979:

Upgrade/Install: Use high-dpi plugin icons on update dashboard.

Reorder the $preferred_icons array for plugins to prefer high-dpi icons (2x) over standard-dpi icons (1x).

Props dd32.
Fixes #43727.

#3 @SergeyBiryukov
13 months ago

#45087 was marked as a duplicate.

#4 @SergeyBiryukov
13 months ago

  • Keywords fixed-major added
  • Milestone changed from 5.0 to 5.0.1
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for 5.0.1 consideration.

#5 @pento
11 months ago

  • Milestone changed from 5.0.1 to 5.0.2

#6 @pento
11 months ago

  • Keywords fixed-major removed
  • Milestone changed from 5.0.2 to 5.1
  • Resolution set to fixed
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.