WordPress.org

Make WordPress Core

Opened 3 weeks ago

Closed 2 weeks ago

Last modified 7 days ago

#43968 closed enhancement (fixed)

Add Request Type into Confirmation Email Subject for GDPR

Reported by: garrett-eclipse Owned by: azaozz
Milestone: 4.9.6 Priority: normal
Severity: normal Version: trunk
Component: Privacy Keywords: gdpr has-patch needs-testing
Focuses: administration Cc:

Description

Hello,

Currently both confirmation requests for export and removal both have the same Subject; [Site Name] Confirm Action

Can we amend this to include the request type into the Subject to avoid confusion and overlooking as well as to avoid threading with the other Confirm Action.

I can definitely see users seeing this as spam and overlooking the confirmation request.

Also maybe Confirmation Request would make more sense than Confirm Action.

So something like; [Site Name] Confirmation Request - Export Personal Data

Thanks

Attachments (3)

Screen Shot 2018-05-04 at 3.25.04 PM.png (20.2 KB) - added by garrett-eclipse 3 weeks ago.
Collapsed Confirmation Email - Doesn't indicate what the request was
43968-with-filter.diff (1.8 KB) - added by desrosj 3 weeks ago.
Add request type to email subject (with filter)
43968-without-filter.diff (869 bytes) - added by desrosj 3 weeks ago.
Add request type to email subject (without filter)

Download all attachments as: .zip

Change History (16)

@garrett-eclipse
3 weeks ago

Collapsed Confirmation Email - Doesn't indicate what the request was

#1 @xkon
3 weeks ago

  • Keywords gdpr added

#2 @desrosj
3 weeks ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 4.9.6

@desrosj
3 weeks ago

Add request type to email subject (with filter)

@desrosj
3 weeks ago

Add request type to email subject (without filter)

#3 @desrosj
3 weeks ago

  • Keywords has-patch needs-testing added; needs-patch removed

Added two patches. One adds the request type to the subject only, and the other adds the request type to the subject and introduces a filter on the email subject.

I am not sure on the rules of introducing a filter after beta if it is adding to a bug fix.

This ticket was mentioned in Slack in #core by desrosj. View the logs.


2 weeks ago

#5 @allendav
2 weeks ago

Tests well. I don't know what the convention for a beta is, but either with or without filters is fine by me.

This ticket was mentioned in Slack in #gdpr-compliance by allendav. View the logs.


2 weeks ago

#7 @allendav
2 weeks ago

Per slack - adding this with the filter is cool for beta. https://wordpress.slack.com/archives/C9695RJBW/p1525883031000710

#8 @azaozz
2 weeks ago

Looking at 43968-without-filter.diff, somewhat unreadable, a big chunk of phpdoc inside a function call... And many multiline args, some nested.

Thinking this should be covered by the coding standards. Highest priority: readability!! No multiline stuff or comments inside of function calls unless "can't live without" :)

#9 @azaozz
2 weeks ago

In 43197:

Privacy: add request type and filter to the subject of request confirmation emails for GDPR.

Props desrosj, azaozz.
See #43968.

#10 @azaozz
2 weeks ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In 43198:

Privacy: add request type and filter to the subject of request confirmation emails for GDPR.

Props desrosj, azaozz.
Merges [43197] to the 4.9 branch.
Fixes #43968.

#11 @azaozz
2 weeks ago

In 43199:

Privacy: remove leftover comment after [43197].

See #43968.

#12 @azaozz
2 weeks ago

In 43200:

Privacy: remove leftover comment after [43197].

Merges [43199] to the 4.9 branch.
See #43968.

#13 @desrosj
7 days ago

  • Component changed from General to Privacy

Moving to the new Privacy component.

Note: See TracTickets for help on using tickets.