Add Request Type into Confirmation Email Subject for GDPR

[garrett-eclipse]

Hello,

Currently both confirmation requests for export and removal both have the same Subject;
[Site Name] Confirm Action

Can we amend this to include the request type into the Subject to avoid confusion and overlooking as well as to avoid threading with the other Confirm Action.

I can definitely see users seeing this as spam and overlooking the confirmation request.

Also maybe Confirmation Request would make more sense than Confirm Action.

So something like;
[Site Name] Confirmation Request - Export Personal Data

Thanks

[garrett-eclipse]

Collapsed Confirmation Email - Doesn't indicate what the request was

[desrosj]

Add request type to email subject (with filter)

[desrosj]

Add request type to email subject (without filter)

[desrosj]

Added two patches. One adds the request type to the subject only, and the other adds the request type to the subject and introduces a filter on the email subject.

I am not sure on the rules of introducing a filter after beta if it is adding to a bug fix.

[allendav]

Tests well. I don't know what the convention for a beta is, but either with or without filters is fine by me.

[allendav]

Per slack - adding this with the filter is cool for beta.
​https://wordpress.slack.com/archives/C9695RJBW/p1525883031000710

[azaozz]

Looking at 43968-without-filter.diff, somewhat unreadable, a big chunk of phpdoc inside a function call... And many multiline args, some nested.

Thinking this should be covered by the coding standards. Highest priority: readability!! No multiline stuff or comments inside of function calls unless "can't live without" :)

[azaozz]

In 43197:

Privacy: add request type and filter to the subject of request confirmation emails for GDPR.

Props desrosj, azaozz.
See #43968.

[azaozz]

In 43198:

Privacy: add request type and filter to the subject of request confirmation emails for GDPR.

Props desrosj, azaozz.
Merges [43197] to the 4.9 branch.
Fixes #43968.

[azaozz]

In 43199:

Privacy: remove leftover comment after [43197].

See #43968.

[azaozz]

In 43200:

Privacy: remove leftover comment after [43197].

Merges [43199] to the 4.9 branch.
See #43968.

[desrosj]

Moving to the new Privacy component.