WordPress.org

Make WordPress Core

Opened 6 weeks ago

Last modified 6 weeks ago

#43978 new defect (bug)

Avoid flickering on the Tools / Export page

Reported by: birgire Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Export Keywords: has-screenshots has-patch
Focuses: administration Cc:

Description

The export filters are hidden by default on the Tools / Export page.

But it's only hidden with Javascript in wp-admin/export.php:

jQuery(document).ready(function($){
    var form = $('#export-filters'),
        filters = form.find('.export-filters');
    filters.hide();

The filters can therefore be visible for a short time, before they are hidden.

Here the filters.hide() will add a display:none; inline styling to the corresponding filters.

We can avoid this flickering with CSS, something like:

#export-filters .export-filters {
    display: none;
}

Attachments (6)

flicker-on-export-tools-page.gif (114.9 KB) - added by birgire 6 weeks ago.
43978.patch (367 bytes) - added by robicse11128 6 weeks ago.
43978.2.patch (663 bytes) - added by robicse11128 6 weeks ago.
Code moved to wp-admin/css/forms.css
43978.diff (338 bytes) - added by pmbaldha 6 weeks ago.
Positioned css at proper location where tools styles reside in forms.css and discard all changes in common.css which are in 43978.2.patch
43978.3.diff (338 bytes) - added by pmbaldha 6 weeks ago.
Positioned css at proper location where tools styles reside in forms.css and discard all changes in common.css which are in 43978.2.patch
43978.3.test-fixed-issue.gif (211.6 KB) - added by pmbaldha 6 weeks ago.
43978.3.gif have resolved the issue

Download all attachments as: .zip

Change History (9)

@robicse11128
6 weeks ago

#1 @birgire
6 weeks ago

Thanks for the patch @robicse11128

These files currently have references to #export-filters or .export-filters:

wp-admin/css/forms.css
wp-admin/css/edit.css

I wonder if either one, would be suitable here. What do you think?

@robicse11128
6 weeks ago

Code moved to wp-admin/css/forms.css

@pmbaldha
6 weeks ago

Positioned css at proper location where tools styles reside in forms.css and discard all changes in common.css which are in 43978.2.patch

@pmbaldha
6 weeks ago

Positioned css at proper location where tools styles reside in forms.css and discard all changes in common.css which are in 43978.2.patch

@pmbaldha
6 weeks ago

43978.3.gif have resolved the issue

#2 @pmbaldha
6 weeks ago

  • Keywords has-patch added; needs-patch removed

#3 @birgire
6 weeks ago

  • Keywords good-first-bug removed

@pmbaldha Thanks for the patch and the screen-animation. That looks good

Mark the good-first-bug as claimed and remove that tag.

Note: See TracTickets for help on using tickets.