Twenty Seventeen: CSS issue when using rowspan in tables

[aussi]

I've spotted an issue with the TwentySeventeen theme. This definition in styles.css:

th:first-child,
td:first-child {
    padding-left: 0;
}

causes problems when using tables containing rowspans. Specifically, this code:

<table width="100%">
  <thead>
    <tr>
      <th>Head 1</th>
      <th>Head 2</th>
    </tr>
  </thead>
  <tbody>
    <tr>
      <td rowspan="3">Cell 1</td>
      <td>Cell 2</td>
    </tr>
    <tr>
      <td>Cell 3</td>
    </tr>
    <tr>
      <td>Cell 4</td>
    </tr>
  </tbody>
</table>

produces a table where Head 2 and Cell 2 have padding-left: 0.4em, while Cell 3 and Cell 4 have padding-left: 0. This produces a table with misaligned cells in the same column.

[subrataemfluence]

We have a 0.4em padding set for all td elements, which makes the content to stay nicely inside the td with an equal small padding all sides.

td {
   padding: 0.4em;
}

But since the pseudo elements :first-child and :last-child have a left padding set to 0 just below the above rule, I feel we need to apply the same for td and th as well. This will ensure all elements would have no left padding but have a padding of 0.4em on other three sides, i.e. top, right and bottom.

The following works for me.

th:first-child,
td:first-child,
td,
th {
   padding-left: 0;
}

[ianbelanger]

Just tested the patch and it does fix the issue on the front-end. It does not work in the editor though. However, this may not matter because the Table Block does not allow you to use rowspan, it gets stripped out or you have to convert it to an HTML Block.

[davidbaumwald]

Based on the latest comments, this ticket still needs some work. With Beta 1 of version 5.3 only a few days away, this is being moved to Future Release. If this ticket can be resolved in time for 5.3, feel free to re-milestone.

[ianbelanger]

Reviewing for commit.

[ianbelanger]

In 48028:

Bundled Themes: Twenty Seventeen CSS issue when using rowspan in tables.

Fixes CSS issue when using rowspan in tables. This issue does not apply to the Table Block, just tables inserted as custom html.

Props aussi, subrataemfluence, jainnidhi.
Fixes #44004.

[ianbelanger]

Reopening for backport.

[desrosj]

With 5.5 just under 5 weeks away, there is no 5.4.3 planned. Moving back to the 5.5 milestone.