#44115 closed defect (bug) (fixed)
Add `esc_html` to get_comment_link
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.9.7 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Comments | Keywords: | fixed-major |
Focuses: | administration | Cc: |
Description
At https://core.trac.wordpress.org/browser/branches/4.9/src/wp-admin/edit-form-comment.php#L27
get_comment_link( ) function getting used without esc_html( )
Attachments (1)
Change History (9)
#1
@
7 years ago
Related ticket:44054#comment:2
In the future, please disclose any missing escape privately, via HackerOne, rather than publicly via Trac.
#2
@
7 years ago
- Keywords needs-patch added
The patch is incorrect. It should be the output that is changed.
<span id="sample-permalink"><a href="<?php echo esc_url( $comment_link ); ?>"><?php echo esc_html( $comment_link ); ?></a></span>
#3
@
7 years ago
- Owner set to iandunn
- Resolution set to fixed
- Status changed from new to closed
In 43290:
#4
@
7 years ago
- Component changed from General to Comments
- Focuses administration added
- Milestone changed from Awaiting Review to 5.0
- Version trunk deleted
Note: See
TracTickets for help on using
tickets.
Adding a patch for it