#44115 closed defect (bug) (fixed)
Add `esc_html` to get_comment_link
| Reported by: | 1naveengiri | Owned by: | iandunn |
|---|---|---|---|
| Priority: | normal | Milestone: | 4.9.7 |
| Component: | Comments | Version: | |
| Severity: | normal | Keywords: | fixed-major |
| Cc: | Focuses: | administration |
Description
At https://core.trac.wordpress.org/browser/branches/4.9/src/wp-admin/edit-form-comment.php#L27
get_comment_link( ) function getting used without esc_html( )
Attachments (1)
Change History (9)
#1
@
9 years ago
Related ticket:44054#comment:2
In the future, please disclose any missing escape privately, via HackerOne, rather than publicly via Trac.
#2
@
9 years ago
- Keywords needs-patch added
The patch is incorrect. It should be the output that is changed.
<span id="sample-permalink"><a href="<?php echo esc_url( $comment_link ); ?>"><?php echo esc_html( $comment_link ); ?></a></span>
#4
@
9 years ago
- Component General → Comments
- Focuses administration added
- Milestone Awaiting Review → 5.0
- Version trunk
Note:
See TracTickets
for help on using tickets.
Adding a patch for it