WordPress.org
Get WordPress

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#44298 closed defect (bug) (fixed)

Invalid return statement in confirmation email expiration error notice

Reported by: itowhid06's profile itowhid06 Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.9.7 Priority: normal
Severity: normal Version: 4.9.6
Component: Users Keywords: has-patch commit fixed-major
Focuses: privacy Cc:

Description

Currently if expiration time is passed, the error message is stored in a variable, which is never returned.

Attachments (1)

patch.diff​ (507 bytes) - added by itowhid06 7 years ago.

Download all attachments as: .zip

Change History (8)

@itowhid06
7 years ago

#1 @itowhid06
7 years ago

  • Focuses privacy added

#2 @desrosj
7 years ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 4.9.7
  • Severity changed from major to normal

Good catch, @itowhid06. Patch looks good to me!

#3 @SergeyBiryukov
7 years ago

Appears to be a copy/paste from check_password_reset_key(), where $return goes through the password_reset_key_expired filter. The patch looks good.

#4 @SergeyBiryukov
7 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 43331:

Users: In wp_validate_user_request_key(), properly return the WP_Error object in case the confirmation email has expired.

Props itowhid06.
Fixes #44298.

#5 @SergeyBiryukov
7 years ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for 4.9.7.

#6 @SergeyBiryukov
7 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 43342:

Users: In wp_validate_user_request_key(), properly return the WP_Error object in case the confirmation email has expired.

Props itowhid06.
Merges [43331] to the 4.9 branch.
Fixes #44298.

#7 @johnbillion
7 years ago

#44403 was marked as a duplicate.

Note: See TracTickets for help on using tickets.