WordPress.org
Get WordPress

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#44298 closed defect (bug) (fixed)

Invalid return statement in confirmation email expiration error notice

Reported by: itowhid06 Owned by: SergeyBiryukov
Priority: normal Milestone: 4.9.7
Component: Users Version: 4.9.6
Severity: normal Keywords: has-patch commit fixed-major
Cc: Focuses: privacy

Description

Currently if expiration time is passed, the error message is stored in a variable, which is never returned.

Attachments (1)

patch.diff​ (507 bytes ) - added by itowhid06 8 years ago.

Download all attachments as: .zip

Change History (8)

@itowhid06
8 years ago

#1 @itowhid06
8 years ago

  • Focuses privacy added

#2 @desrosj
8 years ago

  • Keywords commit added
  • Milestone Awaiting Review → 4.9.7
  • Severity major → normal

Good catch, @itowhid06. Patch looks good to me!

#3 @SergeyBiryukov
8 years ago

Appears to be a copy/paste from check_password_reset_key(), where $return goes through the password_reset_key_expired filter. The patch looks good.

#4 @SergeyBiryukov
8 years ago

  • Owner set to SergeyBiryukov
  • Resolution → fixed
  • Status new → closed

In 43331:

Users: In wp_validate_user_request_key(), properly return the WP_Error object in case the confirmation email has expired.

Props itowhid06.
Fixes #44298.

#5 @SergeyBiryukov
8 years ago

  • Keywords fixed-major added
  • Resolution fixed
  • Status closed → reopened

Reopening for 4.9.7.

#6 @SergeyBiryukov
8 years ago

  • Resolution → fixed
  • Status reopened → closed

In 43342:

Users: In wp_validate_user_request_key(), properly return the WP_Error object in case the confirmation email has expired.

Props itowhid06.
Merges [43331] to the 4.9 branch.
Fixes #44298.

#7 @johnbillion
8 years ago

#44403 was marked as a duplicate.

Note: See TracTickets for help on using tickets.