Confusing Documentation in WP_Term_Query::__construct()

[jeremyescott]

So I'm working on a pesky issue around a get_terms() call that, of course, uses WP_Term_Query::construct() and, while I fixed the issue (it was my fault) I spent some time in docs and in fact I got quite confused by an aspect of documentation, which I fully believe is an error.

from wp-includes/class-wp-term-query.php: 99

/* [...]
 *     @type string       $orderby                Field(s) to order terms by. Accepts term fields ('name',
 *                                                'slug', 'term_group', 'term_id', 'id', 'description', 'parent'),
 *                                                'count' for term taxonomy count, 'include' to match the
 *                                                'order' of the $include param, 'slug__in' to match the
 *                                                'order' of the $slug param, 'meta_value', 'meta_value_num',
 *                                                the value of `$meta_key`, the array keys of `$meta_query`, or
 *                                                'none' to omit the ORDER BY clause. Defaults to 'name'.
 * [...]
 */

My problem is with this bit:

'count' for term taxonomy count,

A term doesn't have taxonomy, right? A taxonomy has terms, but not terms taxonomy. I personally believe this should read (because it matches behavior):

'count' for number of posts in term count

Or something like that.

Is this correct? I don't think I'm crazy, but I'd love a second opinion. If I get some agreement, I'll either happily write a patch or let this one be a "good-first-patch" for a newbie!

[jeremyescott]

I'm so sorry! What a terrible title. I read and re-read the post content and didn't write a proper title.

[subrataemfluence]

Hi welcome to Trac and thanks for the ticket.
Yes, taxonomy has terms, not the other way round!

So I think it could be reworded like this:

...
* 'count' for taxonomy term count
...

[jeremyescott]

Modify document block to more accurately describe the 'count' argument

[jeremyescott]

Documentation is very subjective. Here is a stab at it.

[DrewAPicture]

In 49189:

Docs: Clarify documentation for what the 'count' orderby argument represents in WP_Term_Query.

Props jeremyescott.
Fixes #44443.