WordPress.org

Make WordPress Core

Opened 11 days ago

Closed 4 days ago

Last modified 4 days ago

#44574 closed defect (bug) (fixed)

Saratov and other cities missing from translations

Reported by: dyrer Owned by: SergeyBiryukov
Milestone: 4.9.8 Priority: normal
Severity: normal Version:
Component: I18N Keywords:
Focuses: Cc:

Description

WordPress running with PHP 7.2 in the city list added the city of "Saratov" This is city is missing from translation strings

I have a screenshot attached

Please check

Attachments (2)

saratov.jpg (31.2 KB) - added by dyrer 11 days ago.
City list in administation
44574.diff (1.8 KB) - added by soulseekah 6 days ago.
Saratov + more

Download all attachments as: .zip

Change History (9)

@dyrer
11 days ago

City list in administation

#1 @soulseekah
8 days ago

"Saratov" is indeed missing from the cities and continents translations here: https://translate.wordpress.org/projects/wp/dev/cc

Not sure how the list is generated, but Saratov is a valid timezone under Europe.

#2 @soulseekah
8 days ago

  • Summary changed from Saratov missing to Saratov and other cities missing from translations

#3 follow-up: @soulseekah
8 days ago

44574.diff adds 5 missing locations (according to my system's zoneinfo files) Punta Arenas, Saratov, Atyrau, Famagusta, Yangon.

Just did timezone_identifiers_list and looked at what's missing from src/wp-admin/includes/continents-cities.php

#4 in reply to: ↑ 3 @SergeyBiryukov
6 days ago

  • Milestone changed from Awaiting Review to 4.9.8

Replying to soulseekah:

44574.diff adds 5 missing locations (according to my system's zoneinfo files) Punta Arenas, Saratov, Atyrau, Famagusta, Yangon.

I only see one change (Saratov) in 44574.diff. Could you update the patch with the other missing locations?

@soulseekah
6 days ago

Saratov + more

#5 @soulseekah
6 days ago

Replaced the diff, sorry.

#6 @SergeyBiryukov
4 days ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 43504:

I18N: Update list of continents and cities for the timezone selection.

Props soulseekah, dyrer.
Fixes #44574.

#7 @SergeyBiryukov
4 days ago

In 43505:

I18N: Update list of continents and cities for the timezone selection.

Props soulseekah, dyrer.
Merges [43504] to the 4.9 branch.
Fixes #44574.

Note: See TracTickets for help on using tickets.