WordPress.org

Make WordPress Core

Opened 15 months ago

Last modified 3 weeks ago

#44588 assigned enhancement

Denote the Copy action is complete by updating the Copy button to state 'Copied'

Reported by: garrett-eclipse Owned by: garrett-eclipse
Milestone: 5.4 Priority: normal
Severity: normal Version: 4.9.6
Component: Privacy Keywords: needs-patch
Focuses: administration Cc:
PR Number:

Description

Hello,

With the Suggested Privacy content introduced in 4.9.6 the sections provide a 'Copy' button;
https://i.imgur.com/WP8JmEw.png

It would be nice if once the action is complete that the button would update to state 'Copied' briefly before switching back to 'Copy' for more copying. By switching to 'Copied' temporarily the users gets direct feedback that the copy action was completed so they don't keep clicking the button unnecessarily.

Chers

Attachments (1)

Screen Shot 2018-07-16 at 11.19.30 AM.png (9.8 KB) - added by garrett-eclipse 15 months ago.
Copy Button

Download all attachments as: .zip

Change History (13)

This ticket was mentioned in Slack in #core-privacy by desrosj. View the logs.


15 months ago

#2 @desrosj
15 months ago

  • Focuses administration added; privacy removed
  • Keywords ui-feedback added
  • Milestone changed from Awaiting Review to Future Release

Good find, @garrett-eclipse. This should definitely get improved. I think adding user feedback to indicate the copy happened successfully is a good idea, but I also don't know that there is enough information here. What should the user do after copying? What does "Copy" actually do? Maybe the button could be "Copy to Clipboard".

I am marking this as ui-feedback to explore this a bit more.

#3 @desrosj
15 months ago

It's also worth noting that there is one copy button for the entire suggested text provided with core. Each plugin that suggests text will receive their own copy button. Maybe "Copy Section" after each section, or a way to bulk select the sections to copy would be useful.

#4 @garrett-eclipse
15 months ago

Thanks @desrosj, good thoughts

I've created #44677 to address the verbiage suggestion of 'Copy to Clipboard'.

And created #44678 to address the enhancement idea for bulk copy of sections.

Cheers

#5 @birgire
14 months ago

The "Email Data" button, on the privacy export data page, comes to mind, as it gives an immediate feedback when it's clicked on.

But it can only be clicked once, for each page load.

I think we should be able to click many times on the Copy button, without reloading the page.

I wonder about the following flow, with a javascript timer:

  • Copy button is clicked.
  • Button text changes immediately to "Copied".
  • After n milliseconds, the button text is back to "Copy".

Another one is to have a label near the button showing the state, but it should be cleared when the user copies other sections or makes other manual copies of text on the page. For a very long text (many plugin sections), this might be slower than the first option.

Third option could be to not show any feedback at all (status quo).

ps:

Here's an interesting discussion I found on the topic:

https://ux.stackexchange.com/questions/40950/what-is-the-best-way-to-confirm-something-has-been-copied

#6 @garrett-eclipse
14 months ago

  • Keywords ux-feedback added

Thanks @birgire, I do like the idea of providing feedback directly in the button there so maybe the timer is the best idea.
There was an idea in your link I thought interesting of checking the clipboard to see if the contents is in there and while it's there keep the button as 'Copied' until the clipboard changes.

#7 @garrett-eclipse
7 months ago

  • Keywords needs-patch added; ui-feedback ux-feedback removed
  • Milestone changed from Future Release to 5.3
  • Owner set to garrett-eclipse
  • Status changed from new to assigned

With r45044 from #46647 the clipboard.js library was introduced to core. We should follow the convention presented for the Site Health 'Copy to Clipboard' button on the Privacy Policy guide's Copy button.

This ticket was mentioned in Slack in #core-privacy by garrett-eclipse. View the logs.


3 months ago

#9 @birgire
5 weeks ago

#47998 was marked as a duplicate.

This ticket was mentioned in Slack in #core-privacy by garrett-eclipse. View the logs.


4 weeks ago

This ticket was mentioned in Slack in #core-privacy by garrett-eclipse. View the logs.


4 weeks ago

#12 @davidbaumwald
3 weeks ago

  • Milestone changed from 5.3 to 5.4

@garrett-eclipse This ticket still needs a patch. With version 5.3 Beta 1 landing tomorrow, this enhancement is being moved for consideration in 5.4. If this can be patched for 5.3, feel free to update the ticket.

Note: See TracTickets for help on using tickets.