Opened 6 years ago
Last modified 5 years ago
#44767 reviewing enhancement
dbDelta allow spaces between column names and between lines
Reported by: | soulseekah | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | Future Release | Priority: | normal |
Severity: | normal | Version: | |
Component: | Upgrade/Install | Keywords: | has-patch has-unit-tests |
Focuses: | Cc: |
Description (last modified by )
SQL is hard :( make it accept nicer schema definitions with arbitrary space alignments, blank lines, etc.
Attachments (3)
Change History (15)
#2
follow-up:
↓ 5
@
6 years ago
- Keywords has-patch has-unit-tests added
Let me know if I should merge them into one.
#3
@
6 years ago
- Description modified (diff)
- Summary changed from Some dbDelta improvements to dbDelta allow spaces between column names and between lines
#4
@
6 years ago
Related: #36924 dbDelta(): Support more than one whitespace between field name and its type definition
#5
in reply to:
↑ 2
@
6 years ago
Replying to soulseekah:
Let me know if I should merge them into one.
Yes, please, the patch and the tests should generally be in the same file.
#6
@
6 years ago
@SergeyBiryukov these are two different patches one dealing with whitespace, the other newlines, each with tests inside them. They can be applied separately but I attatched both as one changeset.
#7
@
6 years ago
- Milestone changed from Awaiting Review to 5.0
- Owner set to SergeyBiryukov
- Status changed from new to reviewing
#10
@
6 years ago
- Milestone changed from 5.2 to 5.3
This ticket has not received any attention during the 5.2 cycle. With beta 1 tomorrow, going to punt this to 5.3.
Allows the schema to be written with spaces and tabs between the column name and the type.
Allows the inclusion of empty lines in the SQL: