WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#44895 closed enhancement (fixed)

Outsource network option handling from `populate_network()` to a new `populate_network_meta()`

Reported by: flixos90's profile flixos90 Owned by: flixos90's profile flixos90
Milestone: 5.1 Priority: normal
Severity: normal Version:
Component: Upgrade/Install Keywords: has-patch has-unit-tests
Focuses: multisite Cc:

Description

Currently, populate_network() has too many responsibilities. Populating network meta is an atomic part of it which can easily be outsourced. Furthermore, a new populate_network_meta() function could support an optional $meta parameter to pass custom metadata, and that bit could finally be unit-tested. This came up during work on #41333.

Attachments (1)

44895.diff​ (16.6 KB) - added by flixos90 6 years ago.

Download all attachments as: .zip

Change History (5)

@flixos90
6 years ago

#1 @flixos90
6 years ago

  • Keywords has-patch has-unit-tests added; needs-patch needs-unit-tests removed

#2 @flixos90
6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 43628:

Upgrade/Install: Introduce populate_network_meta(), moving logic out of populate_network().

Fixes #44895. See #41333.

#3 @flixos90
6 years ago

  • Milestone changed from 5.0 to 5.1
  • Resolution fixed deleted
  • Status changed from closed to reopened

Version numbers need to be adjusted to 5.1.0.

#4 @pento
6 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 44449:

Docs: Update @since for populate_network_meta().

Fixes #44895.

Note: See TracTickets for help on using tickets.