Changed meaningless variable name "$r"

[freewebmentor]

Changed meaningless variable name "$r" from wp-include/category-template.php file and also added the documentation for same.

[mukesh27]

Hi @freewebmentor, Welcome to WordPress Trac! Thank you for your ticket.

We have to change all meaningless variables in core as per coding standards.

Also there are many files which used $r as array so if we have to change $r variable then we have to change that variable from all files.

For your information WordPress core wp-includes folder 33 files and wp-admin folder 12 files contain $r variables.

[SergeyBiryukov]

$r is used so that the original $args array is still available to be passed to various hooks.

Newer code uses $parsed_args for that, see [41733] for example.

So let's change $r to $parsed_args across the older code as well for consistency.

[freewebmentor]

@SergeyBiryukov , Thanks for quick review feedback, So I need to update the $r from all the files like wp-includes folder 33 files and wp-admin folder 12 files contain $r variables?

[SergeyBiryukov]

Replying to freewebmentor:

So I need to update the $r from all the files like wp-includes folder 33 files and wp-admin folder 12 files contain $r variables?

At a glance, $r is not always used with wp_parse_args() in those files, sometimes it's a shorthand for $result or $response.

In this ticket, I'd suggest focusing on the instances where $r is used with wp_parse_args(). Once that's done, we can create new tickets for other instances.

[freewebmentor]

@SergeyBiryukov As requested, Please find the updated patch for this changes.

[SergeyBiryukov]

Thanks for the patch!

[pento]

In 45059.2.patch​, I noticed in meta-boxes.php that some of the old references to $r haven't been updated to $parse_args.

Also, this patch has some code formatting issues. It'd be good to run composer run format on it.

[freewebmentor]

Thanks @pento,

I will make the suggested changes and will add the updated Patch.

Replying to pento:

In 45059.2.patch​, I noticed in meta-boxes.php that some of the old references to $r haven't been updated to $parse_args.

Also, this patch has some code formatting issues. It'd be good to run composer run format on it.

[freewebmentor]

Hi @pento

I have updated the meta-boxes.php that some of the old references to $r haven't been updated to $parse_args and also run the composer run format. Please find the updated patch.

[freewebmentor]

updated meta-boxes.php and run composer run format

[SergeyBiryukov]

Missed the 5.2 Beta 1 deadline, moving to 5.3.

[SergeyBiryukov]

In 45667:

Coding Standards: Rename $r variable used with wp_parse_args() to $parsed_args for clarity.

Props freewebmentor.
Fixes #45059.

[SergeyBiryukov]

In 45668:

Coding Standards: Use correct variable in wp_dropdown_categories() after [45667].

See #45059.