WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#45124 closed defect (bug) (fixed)

Typo in REST API Post controller phpunit test: youseeme post type never unregister because of typo.

Reported by: rahulsprajapati's profile rahulsprajapati Owned by: rahulsprajapati's profile rahulsprajapati
Milestone: 5.1 Priority: normal
Severity: minor Version: 4.7
Component: REST API Keywords: has-patch good-first-bug commit
Focuses: Cc:

Description

Post type youseeme registered here during setup of phpunit test: https://core.trac.wordpress.org/browser/trunk/tests/phpunit/tests/rest-api/rest-posts-controller.php?rev=43571#L78
And try to unregister it here https://core.trac.wordpress.org/browser/trunk/tests/phpunit/tests/rest-api/rest-posts-controller.php?rev=43571#L3996 with youseeeme post type.

Here youseeeme should be youseeme

Attachments (2)

45124.diff​ (586 bytes) - added by rahulsprajapati 6 years ago.
Fix typo in _unregister_post_type.
45124.1.diff​ (626 bytes) - added by rahulsprajapati 6 years ago.
Refreshed the patch against the 5.0 branch.

Download all attachments as: .zip

Change History (11)

#1 @SergeyBiryukov
6 years ago

  • Milestone changed from Awaiting Review to 5.0.1

@rahulsprajapati
6 years ago

Fix typo in _unregister_post_type.

#2 @rahulsprajapati
6 years ago

  • Keywords has-patch added; needs-patch removed

#3 follow-up: @desrosj
6 years ago

  • Keywords needs-refresh good-first-bug added
  • Owner set to rahulsprajapati
  • Status changed from new to assigned
  • Version changed from trunk to 4.7

Thanks for the ticket, @rahulsprajapati. And welcome to Trac!

I am marking this as a good-firstbug` and assigning it to you to mark it claimed.

When you have a chance, can you refresh the patch against the 5.0 branch?

#4 @desrosj
6 years ago

  • Severity changed from normal to minor

@rahulsprajapati
6 years ago

Refreshed the patch against the 5.0 branch.

#5 in reply to: ↑ 3 @rahulsprajapati
6 years ago

  • Keywords needs-refresh removed

Replying to desrosj:

Thanks for the ticket, @rahulsprajapati. And welcome to Trac!

I am marking this as a good-firstbug` and assigning it to you to mark it claimed.

When you have a chance, can you refresh the patch against the 5.0 branch?

Hello @desrosj

45124.1.diff is refreshed patch against 5.0 branch.

#6 @pento
6 years ago

  • Milestone changed from 5.0.1 to 5.0.2

#7 @pento
6 years ago

  • Milestone changed from 5.0.2 to 5.0.3

#8 @desrosj
6 years ago

  • Keywords commit added
  • Milestone changed from 5.0.3 to 5.1

This falls outside of the 5.0.3 scope, so punting to 5.1.

#9 @desrosj
6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 44394:

REST API: Fix typo when unregistering test post type.

A typo when unregistering a test post type for the WP_Test_REST_Posts_Controller class was preventing it from being properly removed. youseeme now?

Props rahulsprajapati.
Fixes #45124.

Note: See TracTickets for help on using tickets.