WordPress.org

Make WordPress Core

Opened 12 months ago

Closed 9 months ago

#45155 closed defect (bug) (fixed)

When no menu exists the verbiage is misleading and provides an unnecessary link

Reported by: garrett-eclipse Owned by: pento
Milestone: 5.1 Priority: normal
Severity: normal Version: 4.9.8
Component: Menus Keywords: has-patch commit
Focuses: Cc:
PR Number:

Description

Hello,

On a fresh install which doesn't have menus setup yet, when you go to the Appearance > Menus you'll get a form to Create Menu but before that there's misleading verbiage and a link;
"Edit you menu below, or <create a new menu>"
*I used <> to denote the link text.

This verbiage is misleading as there's no menu below to edit. As well the create a new menu link just links back to the current page so isn't useful.

Suggesting verbiage;
'Create your first menu below.'

The other option is to remove that message box as it's not really needed.

Cheers

Attachments (6)

Screen Shot 2018-10-23 at 4.17.47 PM.png (61.4 KB) - added by garrett-eclipse 12 months ago.
Misleading message when no menus exist
45155.nomessage.diff (902 bytes) - added by garrett-eclipse 12 months ago.
Patch option suppressing message completely
45155.firstmenumessage.diff (686 bytes) - added by garrett-eclipse 12 months ago.
Patch providing message when no menus exist
Screen Shot 2018-10-23 at 4.28.07 PM.png (58.8 KB) - added by garrett-eclipse 12 months ago.
Screen showing when the message area is suppressed
Screen Shot 2018-10-23 at 4.27.51 PM.png (62.5 KB) - added by garrett-eclipse 12 months ago.
Screen showing alternate message when no menus exist
45155.diff (718 bytes) - added by garrett-eclipse 9 months ago.

Download all attachments as: .zip

Change History (13)

@garrett-eclipse
12 months ago

Misleading message when no menus exist

@garrett-eclipse
12 months ago

Patch option suppressing message completely

@garrett-eclipse
12 months ago

Patch providing message when no menus exist

@garrett-eclipse
12 months ago

Screen showing when the message area is suppressed

@garrett-eclipse
12 months ago

Screen showing alternate message when no menus exist

#1 @garrett-eclipse
12 months ago

  • Keywords has-patch needs-refresh dev-feedback ui-feedback ux-feedback needs-testing added

I've provided two patches for this to illustrate the two options;

45155.nomessage.diff - Fully suppresses the message section when there's no menus.

45155.firstmenumessage.diff - Replaces the invalid verbiage with new verbiage and new screen reader verbiage.

#2 @SergeyBiryukov
12 months ago

  • Milestone changed from Awaiting Review to 5.1
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#3 @garrett-eclipse
12 months ago

Thanks @SergeyBiryukov that's what I'm leaning towards as well. Cheers

#4 @garrett-eclipse
9 months ago

  • Keywords needs-refresh dev-feedback ui-feedback ux-feedback needs-testing removed

Hi @SergeyBiryukov I refreshed this patch after re-applying and testing. I found the verbiage could be more clear still.

I ended up with;
'Create your first menu below.'
Screen Reader Text - 'Fill in the Menu Name and click the Create Menu button to create your first menu.'

Thanks for your input earlier, I feel this is ready to commit if you want to take another look.

#5 @garrett-eclipse
9 months ago

  • Keywords commit added

#6 @pento
9 months ago

  • Owner changed from SergeyBiryukov to pento
  • Status changed from reviewing to accepted

#7 @pento
9 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 44685:

Menus: Show an appropriate message when no menus exist.

Props garrett-eclipse.
Fixes #45155.

Note: See TracTickets for help on using tickets.