Comments for translators must be added in script-loader.php

[tobifjellner]

Location: https://core.trac.wordpress.org/browser/branches/5.0/src/wp-includes/script-loader.php
Rows 410-414

<?php
'formats'  => array(
    'time'                => get_option( 'time_format', __( 'g:i a', 'default' ) ),
    'date'                => get_option( 'date_format', __( 'F j, Y', 'default' ) ),
    'datetime'            => __( 'F j, Y g:i a', 'default' ),
    'datetimeAbbreviated' => __( 'M j, Y g:i a', 'default' ),

It is very important to add translator comments for these strings with link to relevant documentation about time and date formats.

[mukesh27]

@tobifjellner, You means needs to remove default text domain?

[tobifjellner]

No, you need to do something like:

<?php
'formats'  => array(
    /* translators: revision date format, see https://secure.php.net/date */
    'time'                => get_option( 'time_format', __( 'g:i a', 'default' ) ),
    /* translators: revision date format, see https://secure.php.net/date */
    'date'                => get_option( 'date_format', __( 'F j, Y', 'default' ) ),
    /* translators: revision date format, see https://secure.php.net/date */
    'datetime'            => __( 'F j, Y g:i a', 'default' ),
    /* translators: revision date format, see https://secure.php.net/date */
    'datetimeAbbreviated' => __( 'M j, Y g:i a', 'default' ),

[mukesh27]

Try this patch.

[tobifjellner]

Hmm. My fault. The text "Revision date format" should be changed into:
"Time format", "Date format", "Date/time format" and "Abbreviated date/time format" respectively.
I was too concentrated on copying the URL correctly from a similar comment in different place that I forgot about the description.

[mukesh27]

updated patch.

[mukesh27]

updated patch.

[SergeyBiryukov]

Related: #45191

[pento]

In 43831:

Script Loader: Add translator comments and remove textdomains.

The inline script for wp-date incorrectly included a textdomain, and lacked translator comments.

Props mukesh27.
Fixes #45191, #45162.

[SergeyBiryukov]

Reopening for trunk.

[pento]

In 44171:

Script Loader: Add translator comments and remove textdomains.

The inline script for wp-date incorrectly included a textdomain, and lacked translator comments.

Merges [43831] from the 5.0 branch to trunk.

Props mukesh27.
Fixes #45191, #45162.