Opened 6 years ago
Closed 6 years ago
#45452 closed defect (bug) (fixed)
Bundled Themes: De-Gutenbergify comments and CSS selectors
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 5.0.2 | Priority: | normal |
| Severity: | normal | Version: | 5.0 |
| Component: | Bundled Theme | Keywords: | has-patch commit fixed-5.0 |
| Focuses: | Cc: |
Description
In the existing default themes, the term "Gutenberg" should be replaced in the block stylesheets with something more future-friendly, like "block-based editor".
In all of the themes, 'Gutenberg' is mentioned at the top of the blocks.css and editor-blocks.css files in a CSS comment, and above the block-based editor CSS enqueue in the functions.php in a PHP comment.
Twenty Seventeen uses the class .gutenberg-editor-page in the editor-blocks.css, in the style:
/* Background color */
.gutenberg-editor-page .editor-block-list__block {
background-color: transparent;
}
Looking at the editor, it looks like the issue this style was meant to fix is no longer present; when the style is removed, the .editor-block-list__block still doesn't have any background colour. So I think this one is safe to remove outright.
Twenty Twelve uses the class .gutenberg in the editor-blocks.css for the widget block styles. These styles are still needed, but this class can be replaced with .editor-block-list__block.
Works great, and patch looks good, @laurelfulford! Verified the two scenarios you discussed in the description.