WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#45502 closed defect (bug) (fixed)

Fallback image URL incorrect for 2x screens

Reported by: desrosj's profile desrosj Owned by:
Milestone: WordPress.org Priority: normal
Severity: normal Version: 5.0
Component: Help/About Keywords: has-patch
Focuses: administration Cc:

Description

In Firefox on a HiDPI screen, the final image source has an incorrect URL. It is listed as https://s.w.org/images/core/5.0/header/twenty-nineteen.jpg and should be https://s.w.org/images/core/5.0/twenty%20nineteen/twenty-nineteen.jpg. This only happens when the window is really wide (greater than 782px).

The former redirects to wordpress.org and causes a "Could not load the image".

Attachments (2)

45502.diff​ (1.5 KB) - added by desrosj 6 years ago.
45502.2.diff​ (2.5 KB) - added by chetan200891 6 years ago.
Refreshed patch.

Download all attachments as: .zip

Change History (9)

@desrosj
6 years ago

#1 @ocean90
6 years ago

  • Component changed from General to Help/About
  • Keywords needs-refresh added

The same for ​https://s.w.org/images/core/5.0/header/Classic.jpg which should be ​https://s.w.org/images/core/5.0/classic/Classic.jpg

#2 @ocean90
6 years ago

I copied the files to the linked directory to fix the redirect. Due to some cache issues the redirect might still be happing but that should be fixed soon-ish.

@chetan200891
6 years ago

Refreshed patch.

#3 @chetan200891
6 years ago

Refreshed patch to fix incorrect URL.

#4 @ocean90
6 years ago

  • Keywords needs-refresh removed

#5 @desrosj
6 years ago

@ocean90 Are your changes meant to be temporary? Or can this be closed out?

#6 @pento
6 years ago

  • Milestone changed from 5.0.1 to 5.0.2

#7 @ocean90
6 years ago

  • Milestone changed from 5.0.2 to WordPress.org
  • Resolution set to fixed
  • Status changed from new to closed

Let's close this as fixed based on comment:2.

Note: See TracTickets for help on using tickets.