WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#45815 closed defect (bug) (fixed)

Build repository has unused '/js' and '/styles' directories

Reported by: dimadin's profile dimadin Owned by:
Milestone: WordPress.org Priority: normal
Severity: major Version:
Component: Build/Test Tools Keywords:
Focuses: Cc:

Description

[44112], which was a merge of [43719] for trunk, created /js and /styles directories in build repository (​[43942] on build . These directories were not created when [43719] was committed in 5.0 branch (​[43548] on build).

After [44159] (which is merge of [43760] for trunk) these directories are no longer used. Corresponding commit in build repository, ​[43989], did not remove these directories. Maybe because there is no code that removes files made during build process?

I am not sure why these directories were not created for 5.0 branch, maybe it's something that trunk had because of [43309]?

Those directories have unprefixed name so they can be in conflict with existing directories of the same name (especially /js), it is not possible to automatically remove them, and since they are now in nightly builds, this needs quick fix.

Change History (6)

This ticket was mentioned in ​Slack in #core by dimadin. ​View the logs.
6 years ago

#2 @netweb
6 years ago

Related: #45455 Webpack "stuck" at old package versions

#3 @ocean90
6 years ago

  • Milestone changed from Awaiting Review to 5.0.3

@atimmer @pento Any idea what may have caused this?

This probably requires a direct commit to core.svn which I can do but we should make sure this doesn't happen again.

#4 @atimmer
6 years ago

@ocean90 My theory about why the 5.0 version of this commit ([43719]) didn't create those folders is because either: That build failed, or that build wasn't triggered and @pento triggered the build manually only after [43760].

As I understand it, the build server doesn't cleanup with every new build it does. So that would be the reason these files are still there. So if you fix it now one core.svn the /js and /styles folders will stay gone.

However, if you want to prevent this category of error you need to make the build server create a clean environment on every commit. I think that is the way most build servers work.

#6 @ocean90
6 years ago

  • Milestone changed from 5.0.3 to WordPress.org
  • Resolution set to fixed
  • Status changed from new to closed
  • Version trunk deleted

@barry implemented a fix to remove the build directory to start clean. The next commit should remove the directories.

Note: See TracTickets for help on using tickets.