WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 5 months ago

#45869 closed defect (bug) (fixed)

Build Tools: Copy un-minified JS to the src directory

Reported by: pento Owned by: pento
Milestone: 5.1 Priority: normal
Severity: normal Version: 5.1
Component: Build/Test Tools Keywords: has-patch
Focuses: Cc:

Description

When running the SCRIPT_DEBUG set to true, we expect a bunch of un-minified JS files to exist, which currently aren't copied to their correct location in the src directory.

This is a followup to #44492.

Attachments (1)

45869.diff (3.6 KB) - added by pento 3 years ago.

Download all attachments as: .zip

Change History (5)

@pento
3 years ago

#1 @pento
3 years ago

45869.diff fixes all of the missing files I've noticed:

  • wp-includes/jquery/ui/*.js
  • wp-includes/underscore.js
  • wp-includes/tinymce/tinymce.js

@atimmer, @omarreiss, could you please review this and see if there's anything else missing?

#2 @pento
3 years ago

  • Owner set to pento
  • Resolution set to fixed
  • Status changed from new to closed

In 44529:

Build Tools: Copy unminified JS files to src.

This allows SCRIPT_DEBUG to be set to true when running from src.

Fixes #45869.

#3 follow-up: @westonruter
3 years ago

I believe I've found another instance. When testing Twenty Fourteen I'm getting a 404 for /wp-includes/js/jquery/jquery.masonry.js?ver=3.1.2b

#4 in reply to: ↑ 3 @desrosj
5 months ago

Replying to westonruter:

I believe I've found another instance. When testing Twenty Fourteen I'm getting a 404 for /wp-includes/js/jquery/jquery.masonry.js?ver=3.1.2b

This is being addressed in #47353. As far as I can tell, the unminified version of jquery-masonry has never been included in Core. But this version only remains as a courtesy (see [27271]).

Note: See TracTickets for help on using tickets.