Make WordPress Core

Opened 6 years ago

Closed 7 months ago

#46048 closed defect (bug) (reported-upstream)

Twenty Nineteen: Latest posts block: Post title overlaps other titles on certain screen widths

Reported by: arunsathiya's profile arunsathiya Owned by:
Milestone: Priority: normal
Severity: normal Version: 5.0.3
Component: Bundled Theme Keywords: has-screenshots has-patch
Focuses: ui Cc:

Description

Affects: Only Twenty Nineteen. Does not affect other core themes like Twenty Seventeen or Twenty Sixteen.

On certain screen widths, with the "Latest posts" Gutenberg block, the long post title overlaps with the nearby titles. This seems to happen only for titles having characters like "/" on it, at the end. I haven't been able to see if this is the case with other special characters.

The attached images can help understand this better.

Video https://cloudup.com/c2G8sjrlp1b showing that this is not affected with other themes like Twenty Seventeen.

Attachments (5)

Screenshot 2019-01-21 at 21.18.01.png (144.3 KB) - added by arunsathiya 6 years ago.
Title overlapping with other titles on "Latest posts" Gutenberg block with Twenty Nineteen
Screenshot 2019-01-21 at 21.18.08.png (184.5 KB) - added by arunsathiya 6 years ago.
Title overlapping with other titles on "Latest posts" Gutenberg block with Twenty Nineteen
46048.patch (1.9 KB) - added by mukesh27 6 years ago.
Patch.
SCR-20240403-qtgi.png (102.5 KB) - added by karmatosed 8 months ago.
Without patch
SCR-20240403-qtja.png (97.0 KB) - added by karmatosed 8 months ago.
With patch

Download all attachments as: .zip

Change History (15)

@arunsathiya
6 years ago

Title overlapping with other titles on "Latest posts" Gutenberg block with Twenty Nineteen

@arunsathiya
6 years ago

Title overlapping with other titles on "Latest posts" Gutenberg block with Twenty Nineteen

#1 @mukesh27
6 years ago

  • Focuses ui added
  • Keywords has-screenshots has-patch ui-feedback added

Hi @arunsathiya, Welcome to WordPres Trac! Thanks for the report.

i also replicate same issue in my setup when string is longer without space, So need to add word-break: break-word; in grid layout CSS.

@mukesh27
6 years ago

Patch.

#2 @laurelfulford
6 years ago

  • Keywords needs-testing added
  • Milestone changed from Awaiting Review to Future Release

This ticket was mentioned in Slack in #design by karmatosed. View the logs.


5 years ago

#4 @nrqsnchz
5 years ago

  • Keywords ui-feedback removed

Removing the ui-feedback label since this is only a visual bug.

#5 @karmatosed
8 months ago

  • Keywords commit added; needs-testing removed
  • Milestone changed from Future Release to 6.6

In testing this does resolve it for me so moving this to recommend commit and also next version, thank you.

@karmatosed
8 months ago

Without patch

@karmatosed
8 months ago

With patch

#6 @karmatosed
8 months ago

  • Keywords dev-feedback added; commit removed

Whilst this patch does fix it I am going to add second opinion as in two-minds about using 'break-word' due to deprecation. We could use 'overflow-wrap: anywhere' but that doesn't work for Safari older versions.

I do know that break-word is used in other themes so for now I am curious what approaches others would take here. Let's get some opinions into this ticket for feedback.

This ticket was mentioned in Slack in #core-themes by karmatosed. View the logs.


7 months ago

#8 @karmatosed
7 months ago

  • Keywords needs-testing added; dev-feedback removed

#9 @karmatosed
7 months ago

This was discussed in today's bug scrub session and it needs to be looked at if the block or the theme is to provide the solution. props @poena for the suggestion.

#10 @poena
7 months ago

  • Keywords needs-testing removed
  • Milestone 6.6 deleted
  • Resolution set to reported-upstream
  • Status changed from new to closed

I can reproduce this problem the latest post block in several themes, both bundled and other,
when the post title is extra long and does not have a space.

It breaks on the front but not in the editors, because there is a generic style for the editor
that hides the problem with the block.

I created a new issue in the Gutenberg repository: https://github.com/WordPress/gutenberg/issues/61347

Aside: One exception is Twenty Twenty-One, because it adds extra CSS for this block:

.wp-block-latest-posts.is-grid {
    word-wrap: break-word;
    word-break: break-word;
}

At the same time, Twenty Twenty-One does not break the word in the next and previous post navigation,
which Twenty Nineteen does. We somehow choose different solutions for each theme, and both themes break but in different places.

Note: See TracTickets for help on using tickets.