User profile checkbox margin issue.

[punit5658]

I found normal style issue in User profile admin area. There is no margin applied some of checkbox due to different HTML. I have added style for it copied from other checkbox generic styles. I will attach pictures to easily identify issue.

[punit5658]

Image 1 - Spacing issue between label and checkbox

[punit5658]

Spacing issue between label and checkbox.

[punit5658]

Spacing issue between label and checkbox after applied patch.

[punit5658]

Spacing issue between label and checkbox after applied patch.

[punit5658]

Spacing issue between label and checkbox patch file.

[afercia]

@punit5658 thanks for your report. This is an interesting case.

As you've noticed, the markup is different. The "Show Toolbar when viewing site" checkbox is wrapped in a <fieldset> element (with a legend) even if it's only one checkbox. Instead, <fieldset> should only be used to group a set of related form controls together.

Turns out a few years ago, when the toolbar was still called "Admin Bar", there were two checkboxes (see attached screenshot). Then, in [18700] this option was simplified to have only one checkbox. However, the fieldset and legend survived to that change.

As there's now no reason to use a <fieldset> and a <legend>, I'd suggest to simply remove them instead of changing the CSS. This would also solve the margin issue in the mobile view.

[afercia]

The show admin bar setting in WordPress 3.2

[punit5658]

@afercia Thanks for looking ticket. Here is your suggested patch.

[punit5658]

Updated patch

[afercia]

In 44756:

Accessibility: Remove unnecessary fieldset and legend elements from the User Profile page.

Also fixes a CSS margin issue in the mobile view.

Props punit5658.
Fixes #46093.