Opened 6 years ago
Closed 5 years ago
#46198 closed task (blessed) (wontfix)
Add additional test for `wp_targeted_link_rel()` when saving and publishing changeset.
Reported by: | peterwilsoncc | Owned by: | dswebsme |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | 5.1 |
Component: | Customize | Keywords: | needs-patch needs-unit-tests reporter-feedback close |
Focuses: | Cc: |
Description
Add tests to the customizer component to ensure the wp_targeted_link_rel()
filters are removed and it does not corrupt the data.
Following up to #45292, see comment #11 on ticket 45292 for approach.
Change History (13)
This ticket was mentioned in Slack in #core by jeffpaul. View the logs.
6 years ago
#5
@
6 years ago
Thanks @desrosj. This one is my top priority now that other issues I was working on are either committed or awaiting feedback.
#8
@
5 years ago
- Milestone changed from 5.2.1 to 5.2.2
This still needs a patch, and 5.2.1 RC is today or tomorrow. The outcome of #47244 will most likely affect the tests written for this ticket.
This ticket was mentioned in Slack in #core by justinahinon. View the logs.
5 years ago
#12
follow-up:
↓ 13
@
5 years ago
- Keywords reporter-feedback close added
- Milestone changed from 5.2.2 to Awaiting Review
5.2.2 RC1 is planned for today, no patch.
Unless I'm missing something, wp_targeted_link_rel()
should not corrupt JSON data any more since [45349].
#13
in reply to:
↑ 12
@
5 years ago
- Milestone Awaiting Review deleted
- Resolution set to wontfix
- Status changed from assigned to closed
Replying to SergeyBiryukov:
Unless I'm missing something,
wp_targeted_link_rel()
should not corrupt JSON data any more since [45349].
That's correct, this can be closed as those tests cover the use case I was considering.
Since this ticket still needs a patch, I'm going to punt this one to 5.2.1. But, test related changes can be committed after RC. @dswebsme if you are able to get this ready before the 5.2 cycle officially closes out, this can be moved back.