Make WordPress Core

Opened 5 years ago

Last modified 16 months ago

#46209 new defect (bug)

mediaelement CSS loading at bottom of body

Reported by: antpb's profile antpb Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 4.9
Component: Media Keywords: needs-patch
Focuses: javascript, coding-standards Cc:

Description (last modified by SergeyBiryukov)

The question was asked in #42751 why we are loading mediaelement css in the body. It was agreed in the recent Media meeting that this is better fit for it's own ticket for discussion.

Mentioned by @themezly :

While we are at it, why are we loading mediaelement CSS files at the bottom of body ?

CSS files should always be in head.

Change History (9)

#1 @SergeyBiryukov
5 years ago

  • Description modified (diff)

#2 @joemcgill
5 years ago

  • Milestone changed from Awaiting Review to 5.3

I'm guessing this is related to #44484, and specifically the changes that were introduced in [41877]. We should look at updating both.

This ticket was mentioned in Slack in #core by david.baumwald. View the logs.

5 years ago

#4 @davidbaumwald
5 years ago

This ticket needs a decision and a patch. With Beta 1 of version 5.3 only a few days away, this is being moved to Future Release. If this ticket can be resolved in time for 5.3, feel free to re-milestone.

#5 @kirasong
5 years ago

  • Focuses javascript added
  • Keywords needs-patch added
  • Version set to 4.9

Should this be classified as a bug like #44484, mentioned earlier in the ticket, is?

#6 @desrosj
5 years ago

  • Type changed from enhancement to defect (bug)

I'm fine with re-classifying this one.

This ticket was mentioned in Slack in #core-media by mike. View the logs.

5 years ago

#8 @davidbaumwald
5 years ago

  • Milestone changed from 5.3 to Future Release

#9 @Mista-Flo
16 months ago

Is this something you can still reproduce? @antpb I'm not sure where to look in the code nor the backend.

Note: See TracTickets for help on using tickets.