404 error in source mapping in jquery.form.min.js

[valicesupport]

Source map error: request failed with status 404

In the latest version of WordPress, the jquery.form.min.js file is referencing a sourceMappingURL at the bottom of the file.

[pento]

Thank you for the bug report, @valicesupport!

This is caused by the build process (grunt copy:npm-packages) copying the minified files from the packages that it's importing, rather than using the uglify part of the build process.

[pento]

In 46218.diff​:

• Don't copy jquery.form.min.js from node_modules, uglify it from jquery.form.js.
• Add a unit test to ensure all JS files in the build directory don't contain a sourceMappingURL directive.
• Remove the ad-hoc unit tests that check backbone.min.js and jquery.js for a sourceMappingURL.

The unit test allows sourceMappingURL=data:... URIs, as these won't cause an extra HTTP request.

[peterwilsoncc]

In 46218.2.diff​:

• adds uglify:jqueryform to uglify:all and precommit:js tasks
• otherwise identical to original patch

I've tested both the grunt watch and grunt build commands to ensure the file is included. It is.

[peterwilsoncc]

In 44740:

Build: Remove source map from jquery.form.min.js.

Minimize jquery.form.js as part of build process to remove the source map reference.

Modify source map tests to include all JavaScript files rather than testing Backbone and jQuery only.

Props pento.
Fixes #46218.

[peterwilsoncc]

In 44744:

Build: Fix formatting issues introduced in [44740].

See #46218.

[peterwilsoncc]

In 44745:

Build: Fix formatting issues introduced in [44740].

Merges [44744] to the 5.1 branch.
See #46218.