WordPress.org

Make WordPress Core

Opened 8 months ago

#46292 new defect (bug)

Bump `set_time_limit()` at the start of the update process, instead of mid-way.

Reported by: dd32 Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Upgrade/Install Keywords: needs-patch
Focuses: Cc:
PR Number:

Description

Currently WordPress calls set_time_limit( 300 ) before it installs an update, however it calls this at the point between unzipping the files, and copying them into place.
For plugins/themes/translations/etc it's this call for core it's this one.

This, combined with the much higher core package sizes (More than doubled since 3.7) results in some people hitting the default php execution cap of 30 seconds during the download phase when testing locally (For example, 11MB @ 2.5mbit/s = 35 seconds).

To make it more 'annoying', The core_upgrader Lock is put in place before the package is downloaded, so if they run into the timeout during downloading, the lock will still be in place in wp_options for 15 minutes.

set_time_limit should be set at the start of the process, likely at the point of the locks being created, before downloads have begun.

Change History (0)

Note: See TracTickets for help on using tickets.