WordPress.org

Make WordPress Core

Opened 6 months ago

Closed 4 months ago

#46514 closed defect (bug) (fixed)

CSS line-height values should be unitless - login.css

Reported by: ianbelanger Owned by: ianbelanger
Milestone: 5.3 Priority: normal
Severity: normal Version:
Component: Login and Registration Keywords: has-patch needs-testing good-first-bug
Focuses: ui, administration, coding-standards Cc:

Description

As outlined in #44643, CSS line-height values should be unitless unless necessary to be defined as a specific pixel value. It was suggested that we break up 44643 by stylesheet in order to better track them.

This ticket covers wp-admin/css/login.css

Note: The patch was tested only on a Windows machine in Chrome, Firefox, IE11 and Edge. As per https://core.trac.wordpress.org/ticket/44643#comment:23 it should probably be tested on other OS's and supported browsers.

Attachments (2)

46514.diff (733 bytes) - added by ianbelanger 6 months ago.
46514.1.diff (752 bytes) - added by ianbelanger 4 months ago.
Updates patch with more precise line-height calculations

Download all attachments as: .zip

Change History (7)

@ianbelanger
6 months ago

#1 @ianbelanger
6 months ago

  • Component changed from General to Login and Registration

#2 @ianbelanger
6 months ago

  • Milestone changed from Awaiting Review to Future Release

#3 @mukesh27
5 months ago

I tested attached patch successfully without any error in Ubuntu 18.04.2 LTS with Google Chrome Version 73.0.3683.75 and Firefox Version 65.0.1

@ianbelanger
4 months ago

Updates patch with more precise line-height calculations

#4 @ianbelanger
4 months ago

  • Milestone changed from Future Release to 5.3

#5 @SergeyBiryukov
4 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 45466:

CSS Coding Standards: Use unitless values for line-height in wp-admin/css/login.css.

Props ianbelanger, pbiron, afercia.
Fixes #46514. See #44643.

Note: See TracTickets for help on using tickets.