WordPress.org
Get WordPress

Make WordPress Core

Opened 8 years ago

Closed 7 years ago

#46514 closed defect (bug) (fixed)

CSS line-height values should be unitless - login.css

Reported by: ianbelanger Owned by: ianbelanger
Priority: normal Milestone: 5.3
Component: Login and Registration Version:
Severity: normal Keywords: has-patch needs-testing good-first-bug
Cc: Focuses: ui, administration, coding-standards

Description

As outlined in #44643, CSS line-height values should be unitless unless necessary to be defined as a specific pixel value. It was suggested that we break up 44643 by stylesheet in order to better track them.

This ticket covers wp-admin/css/login.css

Note: The patch was tested only on a Windows machine in Chrome, Firefox, IE11 and Edge. As per https://core.trac.wordpress.org/ticket/44643#comment:23 it should probably be tested on other OS's and supported browsers.

Attachments (2)

46514.diff​ (733 bytes ) - added by ianbelanger 8 years ago.
46514.1.diff​ (752 bytes ) - added by ianbelanger 7 years ago.
Updates patch with more precise line-height calculations

Download all attachments as: .zip

Change History (7)

@ianbelanger
8 years ago

#1 @ianbelanger
7 years ago

  • Component General → Login and Registration

#2 @ianbelanger
7 years ago

  • Milestone Awaiting Review → Future Release

#3 @mukesh27
7 years ago

I tested attached patch successfully without any error in Ubuntu 18.04.2 LTS with Google Chrome Version 73.0.3683.75 and Firefox Version 65.0.1

@ianbelanger
7 years ago

Updates patch with more precise line-height calculations

#4 @ianbelanger
7 years ago

  • Milestone Future Release → 5.3

#5 @SergeyBiryukov
7 years ago

  • Resolution → fixed
  • Status assigned → closed

In 45466:

CSS Coding Standards: Use unitless values for line-height in wp-admin/css/login.css.

Props ianbelanger, pbiron, afercia.
Fixes #46514. See #44643.

Note: See TracTickets for help on using tickets.