WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Last modified 5 weeks ago

#46577 new defect (bug)

Improve tests related to file permissions for privacy export requests

Reported by: desrosj's profile desrosj Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: Privacy Keywords: has-unit-tests changes-requested
Focuses: tests, privacy Cc:

Description

Continuation of #44233, which tackled adding unit tests for privacy export requests (also see [43630], [44792]).

Some issues were discovered in certain situations with tests asserting the correct behavior when file and directory permissions were incorrectly configured.

Attachments (2)

46577.diff​ (2.1 KB) - added by desrosj 6 years ago.
46577.2.diff​ (2.3 KB) - added by SirLouen 5 weeks ago.
Refreshed patch

Download all attachments as: .zip

Change History (5)

@desrosj
6 years ago

#1 @desrosj
8 months ago

  • Component changed from Build/Test Tools to Privacy
  • Keywords has-patch has-unit-tests needs-testing added

Since this is about adding tests and not a general build or test tooling change, I'm reassigning it to the relevant component.

This ticket was mentioned in ​Slack in #core-test by sppramodh. ​View the logs.
8 months ago

@SirLouen
5 weeks ago

Refreshed patch

#3 @SirLouen
5 weeks ago

  • Focuses tests added
  • Keywords changes-requested added; has-patch needs-testing removed

Test Report

Description

❌ This report can't validate that the indicated patch works as expected.

Patch tested: https://core.trac.wordpress.org/attachment/ticket/46577/46577.2.diff

Environment

  • WordPress: 6.9-alpha-60093-src
  • PHP: 8.2.28
  • Server: nginx/1.27.5
  • Database: mysqli (Server: 8.4.5 / Client: mysqlnd 8.2.28)
  • Browser: Chrome 136.0.0.0
  • OS: Windows 10/11
  • Theme: Twenty Sixteen 3.5
  • MU Plugins: None activated
  • Plugins:
    • Test Reports 1.2.0

Actual Results

  1. ❌ Issue not resolved with the patch.

Additional Notes

  1. This patch is essentially the same as the first one, but I needed to refresh it to apply correctly
  2. ❌ Tests are not currently passing.
  3. Check setExpectedException because its deprecated. Time to switch to expectException
Note: See TracTickets for help on using tickets.