WordPress.org

Make WordPress Core

Opened 2 months ago

Last modified 6 weeks ago

#46681 assigned defect (bug)

Update mediaelement.js to fix Vimeo auto play issues.

Reported by: danieliser Owned by: adamsilverstein
Milestone: Future Release Priority: normal
Severity: normal Version: 5.1
Component: External Libraries Keywords: has-patch
Focuses: Cc:

Description

WP core currently includes mediaelementjs v4.2.6.

Due to recent browser changes Vimeo videos no longer will auto play and often get errors.

A patch was made for this by adding allow="autoplay; fullscreen" here 12 days ago: https://github.com/mediaelement/mediaelement/issues/2618

I propose either:

Master is stable from what I can tell, but as its not versioned and I'm not sure if core would directly accept it without its official release.

This is the specific patch that fixes the Vimeo issue: https://github.com/mediaelement/mediaelement/commit/e84fa56ced5653408203dd0f0db76a05af497720

Personally since core is on 4.2.6 I see no reason we can't feasibly update to the current master branch and mark it as 4.2.9 so that in the future updates will work fine.

Attachments (2)

mediaelementjs_vendor_update.diff (532.6 KB) - added by danieliser 2 months ago.
Patched with latest master branch build of mediaelement.js vendor libraries.
mediaelementjs_scripts_version_changes.diff (2.4 KB) - added by danieliser 2 months ago.
Updated the script-loader.php version for mediaelement vendor library to 4.2.9-a6cc75b (refernce to latest commit hash).

Download all attachments as: .zip

Change History (5)

@danieliser
2 months ago

Patched with latest master branch build of mediaelement.js vendor libraries.

@danieliser
2 months ago

Updated the script-loader.php version for mediaelement vendor library to 4.2.9-a6cc75b (refernce to latest commit hash).

This ticket was mentioned in Slack in #core-js by adamsilverstein. View the logs.


8 weeks ago

#2 @adamsilverstein
8 weeks ago

  • Owner set to adamsilverstein
  • Status changed from new to assigned

#3 @adamsilverstein
6 weeks ago

  • Milestone changed from Awaiting Review to Future Release
Note: See TracTickets for help on using tickets.