WordPress.org

Make WordPress Core

Opened 8 months ago

Closed 5 weeks ago

#46681 closed defect (bug) (fixed)

Update mediaelement.js to fix Vimeo auto play issues.

Reported by: danieliser Owned by: adamsilverstein
Milestone: 5.3 Priority: normal
Severity: normal Version: 5.1
Component: External Libraries Keywords: has-patch needs-testing
Focuses: Cc:
PR Number:

Description

WP core currently includes mediaelementjs v4.2.6.

Due to recent browser changes Vimeo videos no longer will auto play and often get errors.

A patch was made for this by adding allow="autoplay; fullscreen" here 12 days ago: https://github.com/mediaelement/mediaelement/issues/2618

I propose either:

Master is stable from what I can tell, but as its not versioned and I'm not sure if core would directly accept it without its official release.

This is the specific patch that fixes the Vimeo issue: https://github.com/mediaelement/mediaelement/commit/e84fa56ced5653408203dd0f0db76a05af497720

Personally since core is on 4.2.6 I see no reason we can't feasibly update to the current master branch and mark it as 4.2.9 so that in the future updates will work fine.

Attachments (5)

mediaelementjs_vendor_update.diff (532.6 KB) - added by danieliser 8 months ago.
Patched with latest master branch build of mediaelement.js vendor libraries.
mediaelementjs_scripts_version_changes.diff (2.4 KB) - added by danieliser 8 months ago.
Updated the script-loader.php version for mediaelement vendor library to 4.2.9-a6cc75b (refernce to latest commit hash).
46681.diff (544.8 KB) - added by Hareesh Pillai 8 weeks ago.
Updates mediaelement.js from v4.2.6 v4.2.12
46681.2.diff (601.5 KB) - added by adamsilverstein 5 weeks ago.
46681.3.diff (601.6 KB) - added by adamsilverstein 5 weeks ago.
add commit hash since 4.2.13 is unreleased

Change History (15)

@danieliser
8 months ago

Patched with latest master branch build of mediaelement.js vendor libraries.

@danieliser
8 months ago

Updated the script-loader.php version for mediaelement vendor library to 4.2.9-a6cc75b (refernce to latest commit hash).

This ticket was mentioned in Slack in #core-js by adamsilverstein. View the logs.


8 months ago

#2 @adamsilverstein
8 months ago

  • Owner set to adamsilverstein
  • Status changed from new to assigned

#3 @adamsilverstein
7 months ago

  • Milestone changed from Awaiting Review to Future Release

#4 @danieliser
5 months ago

@adamsilverstein - Any word when this will be included? Still getting regular complaints.

@Hareesh Pillai
8 weeks ago

Updates mediaelement.js from v4.2.6 v4.2.12

#5 @Hareesh Pillai
8 weeks ago

  • Keywords needs-testing added

Patch 46681.diff updates mediaelement.js from v4.2.6 to v4.2.12

All the QUnit test cases are passing after this update.

This update includes many bug fixes and a minor accessibility improvement.
Changelog: https://github.com/mediaelement/mediaelement/blob/master/changelog.md

Last edited 8 weeks ago by Hareesh Pillai (previous) (diff)

This ticket was mentioned in Slack in #core by hareesh-pillai. View the logs.


8 weeks ago

This ticket was mentioned in Slack in #core-js by hareesh-pillai. View the logs.


5 weeks ago

#8 @adamsilverstein
5 weeks ago

  • Milestone changed from Future Release to 5.3

@adamsilverstein
5 weeks ago

add commit hash since 4.2.13 is unreleased

#10 @adamsilverstein
5 weeks ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 46436:

External Libraries: upgrade mediaelement to version 4.2.13.

Upgrade mediaelement to the latest version. Includes a variety of bug fixes made since the 4.2.6 release; see https://github.com/mediaelement/mediaelement/releases.

Props danieliser, Hareesh Pillai.
Fixes #46681.

Note: See TracTickets for help on using tickets.