Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#46731 closed enhancement (maybelater)

Site Health: Introduce an 'Expand All' button (at least to the Info screen)

Reported by: garrett-eclipse's profile garrett-eclipse Owned by:
Milestone: Priority: normal
Severity: normal Version: 5.2
Component: Site Health Keywords: site-health has-screenshots needs-patch
Focuses: ui Cc:

Description

Hello,

Amazing work with the Site Health. I appreciate the 'Copy site info' capability as well.

Minor enhancement suggestion would be to add an 'Expand all site info' button above and to the right of the 'Copy site info to clipboard' button would allow users to display all information to easily take a full screenshot or print. Clicking the expand would trigger all accordions to open and switch verbiage to 'Collapse all site info'. Am thinking with the Copy being primary we can have the button a secondary like the 'Passed tests' button.

This could also be introduced to the Status tab but am unsure of placement there.

Thank you for all of the amazing work

Attachments (2)

Screen Shot 2019-03-30 at 12.42.26 AM.png (52.4 KB) - added by garrett-eclipse 5 years ago.
Concept
expand_info.jpg (130.4 KB) - added by xkon 5 years ago.

Download all attachments as: .zip

Change History (10)

#1 @Clorith
5 years ago

  • Keywords site-health added

#2 @afercia
5 years ago

I'd second this. On the main ticket and on GitHub, it was suggested a couple times to give users the option to review the entire report before copying it. At that time, there was a hidden textarea and the proposal was to reveal it before copying. Now that the textarea is gone, offering the ability to expand all the accordions to review the entire report makes totally sense.

See
https://core.trac.wordpress.org/ticket/46573#comment:50
https://github.com/WordPress/health-check/issues/287

The main key is giving people an opportunity to review what they're copying as a block prior to copying to clipboard

@xkon
5 years ago

#3 @xkon
5 years ago

  • Keywords has-screenshots added

I agree that this would be nice to have, we do have to take under account that there's the extra English copy button as well so I'm not really sure which of the 3 ways shown in expand_info.jpg would be the correct one to place the buttons or if there's more as well that I couldn't think of :).

#4 @garrett-eclipse
5 years ago

  • Keywords needs-patch added

Thanks @afercia I appreciate the feedback and agree it's nice to see what you're getting when you click copy.

As well to @xkon thank you, imho I'd go with the 3rd option to reduce space usage. And as they are inline-block I believe they'll naturally break to their own lines as needed by screen real-estate. Good point about the two copy buttons, I hadn't seen that in my example install due to having it en_US.

#5 @Clorith
5 years ago

  • Keywords close added

There's some misinformation here that needs clearing up first, to make sure the right considerations are made.

Any field of debug information may be declared private, making it show up in the output for your eyes only, but not be included in the copied information.

Relating this show-all toggle to wanting to see what information is copied is therefore the wrong basis for such a feature.

In light of the above, I'm not convinced this is a needed feature, especially not this late in the cycle, unless there are accessibility concerns connected to it.

#6 @Clorith
5 years ago

  • Keywords close removed
  • Milestone Awaiting Review deleted
  • Resolution set to maybelater
  • Status changed from new to closed

As there's been no movement on this in the past 5 days, I'm closing it for now.

The current suggestion for buttons also doesn't sit well with me, it shouldn't be grouped with copy-buttons if it is to be included, so a new UI flow needs to exist for this, which I feel we're a bit late for at this time.

It also, as mentioned in comment:5, doesn't truly indicate what information comes with the copy button either, so displaying them for that purpose doesn't make sense.

#7 @garrett-eclipse
5 years ago

Thanks @Clorith sorry I didn't get back to this earlier.

I've moved this to the 'health-check' repo for further discussion - https://github.com/WordPress/health-check/issues/327

In my opinion the ability to expand the accordions provides a couple benefits outside of the copy feature.

  1. Getting a view of everything allows you to quickly scroll through or find specific text.
  2. Many admins will use the site health screen to produce reports either via screenshot or print, as print won't capture unexpanded content allowing admins to quickly expand all information to capture it in a more aesthetic manner than the existing copy will be a great benefit.

It's an amazing tool and I'm sure I'll be using it as described in # 2 above ;)

#8 @spacedmonkey
5 years ago

  • Component changed from Administration to Site Health
Note: See TracTickets for help on using tickets.