WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#46902 closed defect (bug) (fixed)

Coding Standard fixes for wp-admin/includes/class-walker-nav-menu-edit.php

Reported by: sudhiryadav's profile sudhiryadav Owned by: audrasjb's profile audrasjb
Milestone: 5.3 Priority: normal
Severity: minor Version:
Component: Menus Keywords: has-patch commit
Focuses: administration, coding-standards Cc:

Description

Coding Standard fixes for wp-admin/includes/class-walker-nav-menu-edit.php
Fix Yoda condition.

Attachments (2)

46902.patch​ (627 bytes) - added by sudhiryadav 6 years ago.
46902.2.diff​ (675 bytes) - added by audrasjb 6 years ago.
Patch refreshed

Download all attachments as: .zip

Change History (11)

@sudhiryadav
6 years ago

#1 @sudhiryadav
6 years ago

  • Keywords has-patch added

#2 @SergeyBiryukov
6 years ago

  • Component changed from General to Menus
  • Focuses administration coding-standards added

#3 @audrasjb
6 years ago

  • Keywords needs-testing added
  • Milestone changed from Awaiting Review to 5.3

Hi @sudhiryadav, welcome to WordPress Core Trac and thanks for your first ticket!

The patch looks good at a glance. Adding needs-testing keyword and moving it to 5.3.

Cheers,
Jb

#4 @audrasjb
6 years ago

  • Keywords needs-testing removed
  • Owner set to audrasjb
  • Severity changed from normal to minor
  • Status changed from new to accepted

#5 @audrasjb
6 years ago

  • Priority changed from normal to low

#6 @audrasjb
6 years ago

  • Keywords needs-refresh added
  • Priority changed from low to normal

The patch doesn't apply cleanly, adding needs-refresh keyword.

@audrasjb
6 years ago

Patch refreshed

#7 @audrasjb
6 years ago

  • Keywords commit added; needs-refresh removed

In 46902.2.diff: patch refresh. Tested on my side.
Adding commit keyword.

#8 @SergeyBiryukov
6 years ago

Per comment:41:ticket:47632, there's still a discussion to be had over whether we keep using Yoda Conditions in the coding standards or not.

However, since this is only violation in this file, I don't have any objections to this going in.

#9 @SergeyBiryukov
6 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 45697:

Coding Standards: Fix WPCS violations in wp-admin/includes/class-walker-nav-menu-edit.php.

Props sudhiryadav, audrasjb.
Fixes #46902.

Note: See TracTickets for help on using tickets.