Opened 4 years ago
Closed 4 years ago
#46902 closed defect (bug) (fixed)
Coding Standard fixes for wp-admin/includes/class-walker-nav-menu-edit.php
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 5.3 | Priority: | normal |
Severity: | minor | Version: | |
Component: | Menus | Keywords: | has-patch commit |
Focuses: | administration, coding-standards | Cc: |
Description
Coding Standard fixes for wp-admin/includes/class-walker-nav-menu-edit.php
Fix Yoda condition.
Attachments (2)
Change History (11)
#2
@
4 years ago
- Component changed from General to Menus
- Focuses administration coding-standards added
#4
@
4 years ago
- Keywords needs-testing removed
- Owner set to audrasjb
- Severity changed from normal to minor
- Status changed from new to accepted
#6
@
4 years ago
- Keywords needs-refresh added
- Priority changed from low to normal
The patch doesn't apply cleanly, adding needs-refresh
keyword.
#7
@
4 years ago
- Keywords commit added; needs-refresh removed
In 46902.2.diff
: patch refresh. Tested on my side.
Adding commit
keyword.
#8
@
4 years ago
Per comment:41:ticket:47632, there's still a discussion to be had over whether we keep using Yoda Conditions in the coding standards or not.
However, since this is only violation in this file, I don't have any objections to this going in.
Note: See
TracTickets for help on using
tickets.
Hi @sudhiryadav, welcome to WordPress Core Trac and thanks for your first ticket!
The patch looks good at a glance. Adding
needs-testing
keyword and moving it to 5.3.Cheers,
Jb