![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 7 years ago
Closed 7 years ago
#46902 closed defect (bug) (fixed)
Coding Standard fixes for wp-admin/includes/class-walker-nav-menu-edit.php
| Reported by: | sudhiryadav | Owned by: | audrasjb |
|---|---|---|---|
| Priority: | normal | Milestone: | 5.3 |
| Component: | Menus | Version: | |
| Severity: | minor | Keywords: | has-patch commit |
| Cc: | Focuses: | administration, coding-standards |
Description
Coding Standard fixes for wp-admin/includes/class-walker-nav-menu-edit.php
Fix Yoda condition.
Attachments (2)
Change History (11)
#4
@
7 years ago
- Keywords needs-testing removed
- Owner set to
- Severity normal → minor
- Status new → accepted
#6
@
7 years ago
- Keywords needs-refresh added
- Priority low → normal
The patch doesn't apply cleanly, adding needs-refresh keyword.
#7
@
7 years ago
- Keywords commit added; needs-refresh removed
In 46902.2.diff: patch refresh. Tested on my side.
Adding commit keyword.
#8
@
7 years ago
Per comment:41:ticket:47632, there's still a discussion to be had over whether we keep using Yoda Conditions in the coding standards or not.
However, since this is only violation in this file, I don't have any objections to this going in.
Note:
See TracTickets
for help on using tickets.
Hi @sudhiryadav, welcome to WordPress Core Trac and thanks for your first ticket!
The patch looks good at a glance. Adding
needs-testingkeyword and moving it to 5.3.Cheers,
Jb