Opened 7 years ago
Closed 7 years ago
#47255 closed defect (bug) (fixed)
i18n: Use %s placeholders in instead of `mail()`
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 5.3 | Priority: | normal |
| Severity: | normal | Version: | |
| Component: | Keywords: | has-screenshots has-patch | |
| Focuses: | administration | Cc: |
Description
Old translation string:
The email could not be sent. Possible reason: your host may have disabled the mail() function.
New translation string:
The email could not be sent. Possible reason: your host may have disabled the %s function.
Translators cam change the function name by mistake while translating the string. The best practice is to replace the mail() function with a %s placeholder.
The patch also adds translators comments.
Attachments (2)
Change History (8)
#2
@
7 years ago
- Milestone changed from Awaiting Review to 5.3
- Status changed from assigned to reviewing
#4
follow-up:
↓ 5
@
7 years ago
@SergeyBiryukov Why should we care whether it supports HTML? the strings has no HTML.
#5
in reply to:
↑ 4
@
7 years ago
Replying to ramiy:
Why should we care whether it supports HTML? the strings has no HTML.
The current one doesn't have HTML, but the one introduced in [45404] does. I was wondering if that new string could also be used in WP_Recovery_Mode_Email_Service. For now, left a comment on #39110: comment:17:ticket:39110.
Note: See
TracTickets for help on using
tickets.
The string in
wp-login.phpwas changed in [45404]. I'm not sure yet whether the other string should also be updated for consistency (it depends on where it is displayed and whether it supports HTML). A new ticket should probably be opened for that.For now, going with 47255.patch seems fine.