WordPress.org
Get WordPress

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#47355 closed defect (bug) (fixed)

Opening/closing tag mismatch in media templates

Reported by: TravisSeitler Owned by: SergeyBiryukov
Priority: normal Milestone: 5.3
Component: Media Version: 5.0
Severity: normal Keywords:
Cc: Focuses:

Description

When looking into another issue I realized both the #tmpl-audio-details and #tmpl-video-details templates in [src/wp-includes/media-template.php] have mismatched tags for input field labels. (In both cases, the opening tag is a <label> but the closing tag is a </span>.)

#tmpl-audio-details: https://core.trac.wordpress.org/browser/trunk/src/wp-includes/media-template.php#L1138
#tmpl-video-details: https://core.trac.wordpress.org/browser/trunk/src/wp-includes/media-template.php#L1273

Attachments (1)

47355.diff​ (1.5 KB ) - added by TravisSeitler 7 years ago.

Download all attachments as: .zip

Change History (6)

@TravisSeitler
7 years ago

#1 @SergeyBiryukov
7 years ago

  • Component General → Login and Registration
  • Milestone Awaiting Review → 5.3
  • Version → 5.0

Hi @TravisSeitler, welcome to WordPress Trac! Thanks for the ticket.

Introduced in [42444].

#2 @SergeyBiryukov
7 years ago

  • Owner set to SergeyBiryukov
  • Resolution → fixed
  • Status new → closed

In 45381:

Media: Correct closing </label> tags in #tmpl-audio-details and #tmpl-video-details after [42444].

Props TravisSeitler.
Fixes #47355.

#3 @SergeyBiryukov
7 years ago

  • Component Login and Registration → Media

#4 @afercia
7 years ago

Thanks for the ticket and the fix :) @SergeyBiryukov quick question: should tests/qunit/index.html be updated or it's considered legacy and not really used any longer?

#5 @desrosj
7 years ago

#48159 was marked as a duplicate.

Note: See TracTickets for help on using tickets.