Media with fragments duplicate in enclosures

[dshanske]

I am using media fragment ids(​https://www.w3.org/TR/media-frags/) to specify retrieval points in audio/video and the enclosure code picks this up as different enclosures, so I have the same media file multiple times. Suggest duplicate checking in do_enclose after stripping the fragments.

[raaaahman]

Working on it at #WCEU

Edit: Didn't manage to solve it. Feel free to try.

[archduck]

Strip fragments from url

[archduck]

It looks like do_enclose does some checking for duplicate urls already, when it runs the enclosure_links filter - but it doesn't take url fragments into account. This patch adds a check for fragments on new urls and strips them away if present. It only affects the enclosures, so the rest of the markup stays intact.

[dshanske]

@archduck Why check for fragments when the strip fragment function strips regardless? Isn't in more efficient just to run everything through it?

[archduck]

Replying to dshanske:

@archduck Why check for fragments when the strip fragment function strips regardless? Isn't in more efficient just to run everything through it?

Good point. Checking for fragments with parse_url is an unnecessary step here.

Especially since strip_fragment_from_url itself runs parse_url - and so urls with fragments would undergo parse_url a second time.

Better to just send everything through it.

[archduck]

Send all the urls through the fragslasher