#47457 closed defect (bug) (fixed)
Fix the mediaelements player controls bar sizing
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 5.3 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Media | Keywords: | has-screenshots good-first-bug has-patch commit |
Focuses: | ui | Cc: |
Description
In the media views, the mediaelements player controls bar exceeds the width of the video. See attached screenshot.
This happens because the media views stylesheet switches everything to content-box
sizing, while it appears the mediaelements player expects border-box
.
This CSS rule in media-views.css
:
.media-modal * { box-sizing: content-box; }
conflicts with this CSS rule in mediaelementplayer-legacy.min.css
:
.mejs-container, .mejs-container * { box-sizing: border-box; }
Explicitly setting box-sizing: border-box;
with some higher specificity to the mediaplayer .mejs-controls
element fixes the problem.
Attachments (3)
Change History (11)
#2
@
6 years ago
- Keywords commit added
- Owner set to afercia
- Status changed from new to assigned
@vaishalipanchal @chetan200891 thanks for your patches! 47457.2.diff seems a better approach to me, as it's better scoped to only target the player controls (we can't change box-sizing for all the elements in the media views).
This ticket was mentioned in Slack in #core by afercia. View the logs.
6 years ago
#5
@
6 years ago
- Milestone changed from 5.3 to 5.2.2
Let's try to add this one to 5.2.2 as it is self contained and already tested, patched, commited :-)
This ticket was mentioned in Slack in #core by mukeshpanchal27. View the logs.
6 years ago
This ticket was mentioned in Slack in #core by sergey. View the logs.
6 years ago
#8
@
6 years ago
- Milestone changed from 5.2.2 to 5.3
Moving back to 5.3, as 5.2.2 is out and this was not actually reopened for backporting to the branch, so it's only in trunk at the moment.
When moving tickets from the next major release to the next minor, please don't forget to reopen and add the fixed-major
keyword.
Patch.