WordPress.org

Make WordPress Core

Opened 5 months ago

#47460 new defect (bug)

Twenty Nineteen: heading style breaks headings in content added by core or plugins in the front end

Reported by: afercia Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-screenshots
Focuses: Cc:
PR Number:

Description

The Twenty Nineteen style for headings uses some CSS generated content to draw a short horizontal line before the headings.

This comes from the post-section-dash mixin used for various elements, for example the h1-h2 headings, entry-title, author-title, and comments-title.

So far so good. But when "external" content is added to a Twenty Nineteen page, the horizontal line CSS rule targets any H1 and H2 headings.

For example, when adding the media modal in the front end, the modal headings break. See attached screenshots.

This also applies to any content added by plugins when the added content includes H1 and H2 headings.

Seems to me this CSS selectors should be better scoped to try to target only the headings within the theme content:

https://github.com/WordPress/twentynineteen/blob/b604f127c2cae10bd48bbbec0fbbbff2cd31f957/sass/elements/_elements.scss#L55-L58

Attachments (2)

01 Screenshot 2019-06-02 at 10.57.04.jpg (119.3 KB) - added by afercia 5 months ago.
"select" media modal used in the front end
02 Screenshot 2019-06-01 at 22.16.52.jpg (83.8 KB) - added by afercia 5 months ago.
"add media" modal used in the front end

Download all attachments as: .zip

Change History (2)

@afercia
5 months ago

"select" media modal used in the front end

@afercia
5 months ago

"add media" modal used in the front end

Note: See TracTickets for help on using tickets.