Make WordPress Core

Opened 4 years ago

Closed 3 years ago

#47714 closed enhancement (wontfix)

Site Health: Alert about missing tables

Reported by: claudiosanches's profile claudiosanches Owned by:
Milestone: Priority: normal
Severity: minor Version: 5.2
Component: Site Health Keywords:
Focuses: Cc:

Description

In Site Health Database's section could include warnings about missing tables, like WooCommerce does: https://cloudup.com/crVw1cIAvlQ
Sometimes is hard to debug when is missing some database, also this should cause several problems, having a section warning about it will helps a lot of users.

Change History (7)

#1 @Clorith
4 years ago

  • Keywords needs-patch removed

Woo is checking their own custom tables, so I feel this is a separate thing (there's no reason Woo couldn't add a Site Health Check looking for their tables though, if that's something they'd like to do).

As for looking up missing tables from WordPress core, I'm a bit on the fence. I'd have to do some testing, but I would expect your install to be unusable if important tables were missing in the first place, I've not tested that though, so I'll have to do a bit of digging to see how that.

And of course, is this a frequent enough scenario to warrant checks for it in the first place ?

#2 @claudiosanches
4 years ago

@Clorith this isn't related to WooCommerce, we had this idea after having trouble to debug users websites, where for some reason is missing WordPress core tables, when something like that happens it's may become hard to debug for non-dev users. I'm not saying that this is frequent, of course, but it's a tool that can only help people, become easy to debug problems in forums and so on.
I can write a patch for it, it isn't a problem.

#3 @Clorith
4 years ago

  • Keywords reporter-feedback added

How often is this an issue? I must admit I've not heard of this my self, so having some understanding relating to that would help with deciding if this is something that should be looked into or not.

#4 @Clorith
4 years ago

  • Version changed from 5.3 to 5.2

#5 @claudiosanches
3 years ago

How often is this an issue?

Well, not something that happens often for sure, but for regular users it's very hard to debug when some table got removed or damaged because some plugin or by malicious code.

#6 @knutsp
3 years ago

  • Keywords close added

The whole DB schema must be checked, in case structural damage may happen for an average user. Also bad or invalid data may be harmful, like an empty value in an option where an array is expected.

Lost tables are very easy to debug, as it will emit ugly error messages, in log or on page.

IMO: Plugin territory, part of some "WordPress Repair Kit" - not for core.

#7 @Clorith
3 years ago

  • Keywords reporter-feedback close removed
  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

As core has a repair procedure (which you need a constant in wp-config.php to access, thisi s more a lower-level feature, and the checking of tables can't be reliably done without knowing what to check for (which may vary depending on plugins, themes etc).

In light of this, I'm closing this out at this time as wontfix. The issue can of course still be discussed further, and if at any point in time any good reasons for looking into this should come up, we can re-classify this ticket at such a time.

Note: See TracTickets for help on using tickets.