WordPress.org

Make WordPress Core

Opened 3 weeks ago

Last modified 4 days ago

#47798 new enhancement

WP Events Dashboard widget could be improved for multi-days events

Reported by: imath Owned by:
Milestone: 5.3 Priority: normal
Severity: normal Version: 4.8
Component: Administration Keywords: has-patch needs-design-feedback needs-testing
Focuses: ui Cc:

Description

When a WordCamp is a multi-days event, only using a starting date is problematic :

  • It doesn't inform about the WordCamp's length
  • The first day of a WordCamp might be a Contributor Day (It's actually the case that generated this ticket)
  • There is some inconsistency with the schedule on central.wordcamp.org (which displays a range of days).

I've opened a ticket about it on Meta Trac concerning the needed edits (include end_date into the JSON response) for api.wordpress.org/events (4637).

Attached to this ticket you'll find the patch I suggest in order to use, just like the WordCamp Central site does, a range of days in case of multi-days WordCamps.

Attachments (7)

47798.patch (1.4 KB) - added by imath 3 weeks ago.
current-screenshot.png (180.8 KB) - added by iandunn 3 weeks ago.
47798.2.patch (2.0 KB) - added by imath 3 weeks ago.
47798.3.patch (2.0 KB) - added by Hareesh Pillai 3 weeks ago.
47798.3.2.patch (2.0 KB) - added by Hareesh Pillai 3 weeks ago.
Consistent formatting
47798.4.patch (2.0 KB) - added by imath 6 days ago.
47798.4.2.patch (2.0 KB) - added by imath 6 days ago.
Using – at both places

Download all attachments as: .zip

Change History (21)

@imath
3 weeks ago

This ticket was mentioned in Slack in #meta-wordcamp by imath. View the logs.


3 weeks ago

#2 @casiepa
3 weeks ago

@imath, I think this will fail if the WordCamp is 31-Aug until 1-Sep (so different month). An extra check is probably needed if the month is different.

#3 @imath
3 weeks ago

@casiepa thanks a lot for your feedback and « bien vu 😉 », I’ll update the patch so that it does:

  • September 13-14
  • September 30 - October 1

#4 @iandunn
3 weeks ago

  • Keywords needs-design-feedback added

Here's what the current formatting looks like:

https://core.trac.wordpress.org/attachment/ticket/47798/current-screenshot.png

...and here's what it looks like w/ the patch:

https://cldup.com/H5h3x9a267.png

For meetup events, I think it's important to keep the day of the week, since that's much more important in that context.

It's not as important for WordCamps, though, since they're much further in the future and people have more time to plan ahead.

It looks like the patch already takes that into consideration, but I just wanted to state it explicitly, since that's something that was done intentionally when the widget was built.

Using different formats for different events would be visually inconsistent, though, and that might look odd. I'm not sure what a good solution to is, though. Maybe it's not that big of a deal?

@imath
3 weeks ago

#5 @imath
3 weeks ago

To take in account @casiepa 's feedback (the case when a WordCamp is on 2 months) I've just added 47798.2.patch Here's how it looks:

https://cldup.com/-bpWreDQx6.jpg

@Hareesh Pillai
3 weeks ago

Consistent formatting

#6 @Hareesh Pillai
3 weeks ago

  • Focuses ui added
  • Keywords needs-testing added

47798.3.patch has two improvements over the previous one -

  1. Added a space between the dates.
  2. 'August' is changed to 'Aug' - to be consistent with the existing format.

#7 @_DorsVenabili
2 weeks ago

+1 to this request :)

#8 @SergeyBiryukov
2 weeks ago

  • Milestone changed from Awaiting Review to 5.3

This ticket was mentioned in Slack in #design by karmatosed. View the logs.


7 days ago

#10 @melchoyce
7 days ago

Super minor, can we be sure to use an en dash instead of a hyphen between date values? https://practicaltypography.com/hyphens-and-dashes.html

#11 @melchoyce
7 days ago

One other comment — the “18 h 00 min” in @imath's last screenshot is confusing, IMO. Is that 18 hours until the event? Or the event itself is 18 hours long? Why is that information important?

#12 @imath
6 days ago

Thanks a lot for your feedback @melchoyce : I haven't touch to how Meetups are displayed, the "18 h 30 min" is the meeting hour in French way of displaying a meeting time.

It depends on the date/hour settings of WordPress. I guess it must be something like "6:30 pm" for en_US. For instance on this new screenshot below, I've used an en dash and changed my WordPress settings to use another way to display hours.

https://cldup.com/xAIr06FPgc.png

47798.4.patch is using an en dash instead of an hyphen when WordCamps are more than one day long.

I've read @hareesh-pillai feedback about using a "short month" format for WordCamps. I think it's important to be consistent with how it is displayed on central.wordcamp.org. That's why I'm using a "full month" format.

Last edited 6 days ago by imath (previous) (diff)

@imath
6 days ago

@imath
6 days ago

Using – at both places

#13 @melchoyce
6 days ago

Ahh okay, thanks for the info! That makes sense.

#14 @mapk
4 days ago

Taking a look at the screenshots from @imath, the latest one looks great! The time makes sense, and I'm all for keeping the full month name as well. Using an en-dash between the days is also correct usage. This looks good!

Note: See TracTickets for help on using tickets.