WordPress.org

Make WordPress Core

Opened 3 months ago

Closed 2 months ago

#47815 closed defect (bug) (fixed)

Align button for `row-actions`

Reported by: jobthomas Owned by: SergeyBiryukov
Milestone: 5.3 Priority: normal
Severity: minor Version:
Component: Administration Keywords: has-patch
Focuses: ui, administration Cc:
PR Number:

Description

On mobile, the line-height for .widefat td is overridden by button in the forms.css resulting in a line-height of 16px rather than 1.5em (or 19.5px which all the a elements in the row-actions have).

Suggested fix:

wp-admin/css/list-tables.css line 1921-1925:

@media screen and (max-width: 782px) {
  .row-actions span .button-link, .row-actions span a {
    display: inline-block;
    padding: 4px 0;
    line-height: 1.5em; //add this line
  }
}

(line-height added at this specific level)

In this screencast, you can see that "Quick-edit" goes down to the right line of both "Edit" and "Trash" when line-height is enabled: https://cld.wthms.co/QfkOuV

Attachments (3)

Screen Shot 2019-08-01 at 12.25.24.png (14.5 KB) - added by jobthomas 3 months ago.
screenshot of issue
Screen Shot 2019-08-01 at 12.11.26.png (4.1 KB) - added by jobthomas 3 months ago.
cause of the faulty line-height
47815.patch (381 bytes) - added by burhandodhy 3 months ago.
Code changes as per @jobthomas suggestion

Download all attachments as: .zip

Change History (6)

@jobthomas
3 months ago

screenshot of issue

@jobthomas
3 months ago

cause of the faulty line-height

@burhandodhy
3 months ago

Code changes as per @jobthomas suggestion

#1 @jobthomas
2 months ago

  • Keywords has-patch added; needs-patch removed

#2 @SergeyBiryukov
2 months ago

  • Milestone changed from Awaiting Review to 5.3
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#3 @SergeyBiryukov
2 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 45756:

Administration: Correct "Quick Edit" link height in list tables for consistency with other action links.

Props jobthomas, burhandodhy.
Fixes #47815.

Note: See TracTickets for help on using tickets.