Make WordPress Core

Opened 5 months ago

Last modified 3 months ago

#47880 new task (blessed)

Extend unit tests for Site Health component.

Reported by: peterwilsoncc Owned by:
Milestone: 5.4 Priority: normal
Severity: normal Version: 5.2
Component: Site Health Keywords: needs-unit-tests needs-patch
Focuses: Cc:
PR Number:


A file for site health check unit tests has been added in tests/phpunit/tests/site-health.php.

At the time of writing it only includes tests for various states of cron, expanding these would help with future development of the component.

Change History (6)

#1 @Clorith
5 months ago

  • Milestone changed from Awaiting Review to 5.3
  • Type changed from enhancement to task (blessed)

Agreed, some inspiration can be taken from the plugin (https://github.com/WordPress/health-check/tree/master/tests/phpunit), although the tests there also need to be expanded upon as they're fairly limited at this time, and relate more to user experience (in the relation of the Site Health Checks).

I'm going to flag this for 5.3, to get some traction, but with the knowledge it may end up getting bumped to 5.4 as well, and change it to a task as unit tests can be added throughout betas so we don't stop any momentum gained.

#2 @desrosj
4 months ago

  • Keywords needs-patch added
  • Version set to 5.2

This ticket was mentioned in Slack in #core-site-health by afragen. View the logs.

4 months ago

#4 @afragen
4 months ago

  • Milestone changed from 5.3 to 5.4

This ticket was mentioned in Slack in #core-site-health by peterwilsoncc. View the logs.

4 months ago

#6 @rukkykf
3 months ago

I'd like to get to work on this. Will take a while though, I'm still working on getting familiar with the codebase.

Note: See TracTickets for help on using tickets.