WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#48181 closed defect (bug) (fixed)

Further adapt WP_Block_Styles_Registry for WordPress core

Reported by: davidbinda's profile david.binda Owned by: desrosj's profile desrosj
Milestone: 5.3 Priority: normal
Severity: normal Version: 5.3
Component: Editor Keywords: has-patch commit
Focuses: Cc:

Description

The WP_Block_Styles_Registry backported from Gutenberg to WordPress in #48039 might need some further adaptation, similar to what has been done for WP_Block_Type_Registry in terms of https://core.trac.wordpress.org/ticket/45097#comment:4

  • Update @package to WordPress and @subpackage to Blocks ( instead of Gutenberg ).
  • Remove 'gutenberg' textdomain.
  • Update deprecated since to 5.3.0 ( instead of 6.2.0 ).

Attachments (1)

48181.diff​ (1.8 KB) - added by david.binda 6 years ago.

Download all attachments as: .zip

Change History (4)

@david.binda
6 years ago

#1 @desrosj
6 years ago

  • Component changed from General to Editor
  • Keywords has-patch commit added
  • Milestone changed from Awaiting Review to 5.3

#2 @desrosj
6 years ago

  • Owner set to desrosj
  • Status changed from new to assigned

#3 @desrosj
6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 46351:

Docs: Correct WP_Styles_Registry documentation.

This change updates the file’s docblock to correctly indicate WordPress/Blocks as the @package/@subpackage, updates the _doing_it_wrong() versions to 5.3.0 instead of the Gutenberg plugin versions, and removes some stray gutenberg text domains.

Props david.binda.
Fixes #48181.

Note: See TracTickets for help on using tickets.