Make WordPress Core

Opened 5 years ago

Last modified 19 months ago

#48221 reopened defect (bug)

Improve punctuation consistency for labels on Add New User and Edit User screens

Reported by: sarvarshaikh's profile sarvarshaikh Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Users Keywords: needs-design-feedback has-patch needs-testing
Focuses: ui, administration Cc:

Description

In the WordPress dashboard in Users->Add New -> Send User Notification. There is one checkbox in at
last (. dot ) there is not suitable
please follow the link https://monosnap.com/file/OWnvrbDahfTn93eh1NaRodpuQJy4Mb

Attachments (2)

edit user screen.png (237.6 KB) - added by desrosj 4 years ago.
profile-page-checkbox.png (263.1 KB) - added by robinwpdeveloper 20 months ago.

Download all attachments as: .zip

Change History (14)

#1 @sarvarshaikh
5 years ago

  • Resolution set to invalid
  • Status changed from new to closed

#2 @SergeyBiryukov
5 years ago

  • Component changed from General to Users
  • Focuses administration added

#3 @desrosj
5 years ago

  • Milestone Awaiting Review deleted

#4 @sarvarshaikh
5 years ago

  • Resolution invalid deleted
  • Status changed from closed to reopened

#5 @desrosj
4 years ago

  • Keywords needs-design-feedback 2nd-opinion reporter-feedback added
  • Milestone set to Awaiting Review
  • Version 5.2.3 deleted

Hi @sarvarshaikh,

Can you detail the reasoning behind your recommendation to remove the period from the end of the sentence? Looking through the Add New and Edit User screens, it looks like the period is more consistently included than not.

Having looked at that, I lean towards leaving the . on that screen and adding it where it's missing on Edit User.

I'm going to tag this for Design/UI feedback in case there have been changes elsewhere in Core towards either option.

This ticket was mentioned in Slack in #design by estelaris. View the logs.


4 years ago

This ticket was mentioned in Slack in #design by paaljoachim. View the logs.


3 years ago

This ticket was mentioned in PR #1889 on WordPress/wordpress-develop by bradp.


2 years ago
#8

  • Keywords has-patch added

Adds periods to the end of labels on user edit screens for consistency.

Trac ticket: #48221

#9 @bradparbs
2 years ago

  • Keywords needs-testing added; 2nd-opinion reporter-feedback removed

I've opened a PR that adds periods to the fields on the user edit screen, so everything is consistent.

#10 @robinwpdeveloper
20 months ago

From my point of view, I think dot (.) should be removed from the checkbox label. Checkbox label has no dots on other User sub menus as well as Settings sub menus.

Text which has dot (.) at the end are more likely short description of the field.

#11 @SergeyBiryukov
20 months ago

  • Summary changed from In WordPress grammatical mistake. to Improve punctuation consistency for labels on Add New User and Edit User screens

#12 @robinwpdeveloper
19 months ago

@SergeyBiryukov can you please share your opinion here so that we can move forward with this ticket.

Thank you.

Note: See TracTickets for help on using tickets.