WordPress.org
Get WordPress

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#48444 closed defect (bug) (fixed)

Travis needs to allow memcache to be installed in a different repo name from `wordpress-develop`

Reported by: whyisjake's profile whyisjake Owned by: whyisjake's profile whyisjake
Milestone: 5.3 Priority: normal
Severity: normal Version: 5.3
Component: Build/Test Tools Keywords: has-patch commit dev-reviewed
Focuses: Cc:

Description

If someone clones the wordpress-develop repo into a new directory that isn't named wordpress-develop the installer will fail as it is assuming since that path is hard-coded into the .travis.yml file. We should allow that to be dynamic.

Attachments (1)

48444.diff​ (593 bytes) - added by whyisjake 5 years ago.

Download all attachments as: .zip

Change History (9)

@whyisjake
5 years ago

#1 @whyisjake
5 years ago

  • Component changed from General to Build/Test Tools

#2 @whyisjake
5 years ago

  • Owner set to whyisjake
  • Resolution set to fixed
  • Status changed from new to closed

In 46605:

Build/Test Tools: Don't hardcode the directory name of the repo

When Travis builds the directory, it was looking for a hardcoded wordpress-develop directory. If the repo is sitting in another directory, the memcache install will fail. This allows a dynamic path for the directory.

Fixes #48444.
Props pento, whyisjake.

#3 @pento
5 years ago

  • Milestone changed from Awaiting Review to 5.4

#4 @desrosj
5 years ago

I think this would make sense to backport to 5.3.

5.3 is the (currently) first branch that contains the local Docker environment, so I think it would be beneficial to contain this fix.

#5 @whyisjake
5 years ago

Yeah, totally agree about bringing this change to 5.3 too. Wanted to get some dev feedback and such as.

#6 @desrosj
5 years ago

  • Keywords commit dev-feedback added
  • Milestone changed from 5.4 to 5.3
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening and marking for a second committer sign off to backport. This is a test related change, so won't effect the packaged/released version.

#7 @SergeyBiryukov
5 years ago

  • Keywords dev-reviewed added; dev-feedback removed

Looks good.

#8 @whyisjake
5 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 46615:

Build/Test Tools: Don't hardcode the directory name of the repo

When Travis builds the directory, it was looking for a hardcoded wordpress-develop directory. If the repo is sitting in another directory, the memcache install will fail. This allows a dynamic path for the directory.

Fixes #48444.

Props pento, whyisjake.

Note: See TracTickets for help on using tickets.