#48517 closed task (blessed) (fixed)
Fix default theme headers to add `Requires at least` and `Requires PHP` headers
Reported by: | afragen | Owned by: | Otto42 |
---|---|---|---|
Milestone: | 5.3 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Bundled Theme | Keywords: | has-patch commit dev-reviewed |
Focuses: | Cc: |
Description
Per the discussion in #48515 this ticket is to have the headers for all the default themes have their respective Requires at least
and Requires PHP
headers in the style.css
files.
Also, please do not include the WordPress
in the version number for the Requires at least
header.
The need is for consistency in showing other themes that these data are important and going to be import for theme compatibility testing in core.
Attachments (2)
Change History (16)
This ticket was mentioned in Slack in #core-themes by afragen. View the logs.
5 years ago
#2
@
5 years ago
- Component changed from Themes to Bundled Theme
- Milestone changed from Awaiting Review to 5.4
#3
@
5 years ago
- Milestone changed from 5.4 to 5.3
- Owner set to Otto42
- Status changed from new to accepted
- Type changed from defect (bug) to task (blessed)
@
5 years ago
Move all the relevant headers to the correct locations, standardize the format to be version numbers only, suitable for reading by code.
#5
@
5 years ago
- Keywords has-patch commit added; needs-patch removed
Patch added which moves all the Requires headers to the style.css files, and removes the "WordPress" from preceding the version numbers. The "Tested up to" headers remains in the readme files, since core does not read this header.
#6
@
5 years ago
Thanks @Otto42! 48517.2.diff just runs the related RTL build tasks in Twenty Nineteen and Twenty Twenty to ensure the headers are fixed in the -rtl
stylesheets. They are not read, but the files are direct copies with RTL transformations, so good to keep them in sync.
For Twenty Twenty, I also opened a PR to make the changes up stream. While development there will soon die down, I think it's good to sync that over just in case a few changes are copied back over to SVN before official release.
#8
@
5 years ago
- Keywords dev-feedback added
- Resolution fixed deleted
- Status changed from closed to reopened
Reopening to backport to 5.3.
This ticket was mentioned in Slack in #core by desrosj. View the logs.
5 years ago
#11
@
5 years ago
[46676] looks good to backport, though it does feel weird to me that Requires at least
and Tested up to
are now defined in different files. As noted in comment:30:ticket:48515, I think it would make more sense to define them in a single place, for consistency. Even though core only reads Tested up to
from the API response and not from headers at the moment, that would open such a possibility in the future. But I'll leave that for #meta4621.
Patch coming tomorrow. We can get this into 5.3 since it's a non code change, and all the default themes are changing anyway. Save ourselves some future effort.