WordPress.org

Make WordPress Core

#48615 closed defect (bug) (reported-upstream)

parameter types for both parameters of set_image_handler use invalid phpdoc keywords

Reported by: diddledan Owned by:
Milestone: Priority: normal
Severity: trivial Version: 5.4
Component: External Libraries Keywords: has-patch close
Focuses: docs Cc:

Description

In wp-includes/class-simplepie.php.php the param types of set_image_handler are both documented as str, which is not a valid keyword according to the phpdoc specification: https://docs.phpdoc.org/guides/types.html

The attached patch corrects str to be string.

Attachments (1)

48615.patch (1.0 KB) - added by diddledan 13 months ago.
Patch to set param types to string

Download all attachments as: .zip

Change History (4)

@diddledan
13 months ago

Patch to set param types to string

#1 @SergeyBiryukov
13 months ago

  • Component changed from Feeds to External Libraries
  • Keywords close added

Thanks for the ticket and the patch! Please note that SimplePie is an external library, any changes to its files should be submitted upstream: https://github.com/simplepie/simplepie.

#2 @diddledan
11 months ago

These changes are merged into upstream version 1.5.4 (git tag 1.5.4-fixed): https://github.com/simplepie/simplepie/releases/tag/1.5.4-fixed

#3 @SergeyBiryukov
11 months ago

  • Milestone Awaiting Review deleted
  • Resolution set to reported-upstream
  • Status changed from new to closed

Thanks for the follow-up! This should be resolved by #36669 then.

Note: See TracTickets for help on using tickets.