WordPress.org

Make WordPress Core

Opened 9 months ago

Closed 2 weeks ago

#48703 closed task (blessed) (maybelater)

Update compressed images for a clean precommit:image output

Reported by: SergeyBiryukov Owned by: whyisjake
Milestone: Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords:
Focuses: Cc:

Description (last modified by SergeyBiryukov)

Previously:

Background: #48203

grunt-contrib-imagemin was updated in [46404] and some GIF images were re-minified, however I still get a bunch of changed files after running grunt imagemin:

src/wp-admin/images/loading.gif
src/wp-admin/images/media-button-image.gif
src/wp-admin/images/media-button-video.gif
src/wp-admin/images/resize-2x.gif
src/wp-admin/images/resize-rtl-2x.gif
src/wp-admin/images/resize-rtl.gif
src/wp-admin/images/resize.gif
src/wp-admin/images/sort-2x.gif
src/wp-admin/images/spinner-2x.gif
src/wp-admin/images/spinner.gif
src/wp-admin/images/wpspin_light-2x.gif
src/wp-admin/images/wpspin_light.gif
src/wp-includes/images/smilies/icon_cry.gif
src/wp-includes/images/smilies/icon_lol.gif
src/wp-includes/images/smilies/icon_redface.gif
src/wp-includes/images/spinner-2x.gif
src/wp-includes/images/spinner.gif
src/wp-includes/images/wpspin-2x.gif
src/wp-includes/images/wpspin.gif

Per a quick check in Slack, this is the case for other committers as well, so it seems like the files should be updated.

Attachments (1)

Screen Shot 2019-11-22 at 10.22.17 AM.png (548.7 KB) - added by whyisjake 9 months ago.

Download all attachments as: .zip

Change History (15)

This ticket was mentioned in Slack in #core-committers by sergey. View the logs.


9 months ago

#2 @whyisjake
9 months ago

I was going to commit, but my list is different @SergeyBiryukov.

➜  wordpress-develop svn status
M       src/wp-admin/images/bubble_bg-2x.gif
M       src/wp-admin/images/bubble_bg.gif
M       src/wp-admin/images/date-button-2x.gif
M       src/wp-admin/images/date-button.gif
M       src/wp-admin/images/loading.gif
M       src/wp-admin/images/media-button-image.gif
M       src/wp-admin/images/media-button-music.gif
M       src/wp-admin/images/media-button-other.gif
M       src/wp-admin/images/media-button-video.gif
M       src/wp-admin/images/wpspin_light-2x.gif
M       src/wp-admin/images/wpspin_light.gif
M       src/wp-admin/images/xit-2x.gif
M       src/wp-admin/images/xit.gif
M       src/wp-includes/images/smilies/icon_arrow.gif
M       src/wp-includes/images/smilies/icon_biggrin.gif
M       src/wp-includes/images/smilies/icon_confused.gif
M       src/wp-includes/images/smilies/icon_cool.gif
M       src/wp-includes/images/smilies/icon_cry.gif
M       src/wp-includes/images/smilies/icon_eek.gif
M       src/wp-includes/images/smilies/icon_evil.gif
M       src/wp-includes/images/smilies/icon_exclaim.gif
M       src/wp-includes/images/smilies/icon_idea.gif
M       src/wp-includes/images/smilies/icon_lol.gif
M       src/wp-includes/images/smilies/icon_mad.gif
M       src/wp-includes/images/smilies/icon_mrgreen.gif
M       src/wp-includes/images/smilies/icon_neutral.gif
M       src/wp-includes/images/smilies/icon_question.gif
M       src/wp-includes/images/smilies/icon_razz.gif
M       src/wp-includes/images/smilies/icon_redface.gif
M       src/wp-includes/images/smilies/icon_rolleyes.gif
M       src/wp-includes/images/smilies/icon_sad.gif
M       src/wp-includes/images/smilies/icon_smile.gif
M       src/wp-includes/images/smilies/icon_surprised.gif
M       src/wp-includes/images/smilies/icon_twisted.gif
M       src/wp-includes/images/smilies/icon_wink.gif
M       src/wp-includes/images/wpspin-2x.gif
M       src/wp-includes/images/wpspin.gif
M       src/wp-includes/images/xit-2x.gif
M       src/wp-includes/images/xit.gif

#3 @whyisjake
9 months ago

I can't seem to get this script to settle. It wants to keep pulling a few more bytes out each time you run the script.

This seems a little suboptimal...

#4 @SergeyBiryukov
8 months ago

It gets weirder :)

  • The initial list from the ticket description is what I get after running the precommit:image task on Windows 10.
  • Despite SVN reporting binary file differences, there are actually no differences when comparing the file contents.
  • The only actual difference for me is src/wp-admin/images/loading.gif, which keeps changing size between 1373 and 1369 bytes.
  • At one point I also got differences in src/wp-includes/images/smilies/icon_redface.gif changing between 645 and 641 bytes, but it's not as consistent as loading.gif. This is still on Windows 10.
  • When running npm run grunt precommit:image on a Git checkout on Ubuntu 18.04 LTS, this is the list I get:
    src/wp-admin/images/loading.gif
    src/wp-admin/images/media-button-image.gif
    src/wp-admin/images/media-button-video.gif
    src/wp-admin/images/wpspin_light-2x.gif
    src/wp-admin/images/wpspin_light.gif
    src/wp-includes/images/smilies/icon_redface.gif
    src/wp-includes/images/wpspin-2x.gif
    src/wp-includes/images/wpspin.gif
    
    Again, no actual differences in file contents, just Git reporting binary file changes.

#5 @SergeyBiryukov
5 months ago

  • Milestone changed from 5.4 to Future Release
  • Summary changed from Update compressed images for 5.4 to Update compressed images

This is still relevant, but it's still not quite clear to me what causes SVN to report binary file differences if there are no actual differences when comparing the file contents.

Since it doesn't affect the build in a significant way, moving to a future release for further investigation.

Last edited 5 months ago by SergeyBiryukov (previous) (diff)

This ticket was mentioned in Slack in #core by sergey. View the logs.


4 months ago

#7 @SergeyBiryukov
4 months ago

  • Description modified (diff)
  • Milestone changed from Future Release to 5.5
  • Summary changed from Update compressed images to Update compressed images for 5.5

This ticket was mentioned in Slack in #core by sergey. View the logs.


4 months ago

#9 @whyisjake
7 weeks ago

  • Owner set to whyisjake
  • Status changed from new to accepted

#10 @whyisjake
4 weeks ago

I ran this again and got the exact same list of files from comment:2.

Last edited 4 weeks ago by SergeyBiryukov (previous) (diff)

#11 @desrosj
4 weeks ago

I am also seeing the changes from comment:2.

This ticket was mentioned in Slack in #core by whyisjake. View the logs.


2 weeks ago

#13 @whyisjake
2 weeks ago

I don't love how this isn't a guaranteed fix. Thinking we should close this out, and maybe look at another solution.

#14 @SergeyBiryukov
2 weeks ago

  • Milestone 5.5 deleted
  • Resolution set to maybelater
  • Status changed from accepted to closed
  • Summary changed from Update compressed images for 5.5 to Update compressed images for a clean precommit:image output
Note: See TracTickets for help on using tickets.