Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#48752 closed enhancement (invalid)

On click on visisble password button there is a unnecessary border which blinks on click, it does not suits

Reported by: ronakganatra Owned by: ronakganatra
Milestone: Priority: normal
Severity: normal Version:
Component: Login and Registration Keywords: has-patch close
Focuses: ui, accessibility, css Cc:


On click of view password, A unnecessary border is showing and hiding so it looks like blinking issue and it doesn't looks good as a user perspective. Also it is not necessary.



After updating it looks like:

Attachments (3)

48752-password-visible-blink-issue.diff (638 bytes) - added by ronakganatra 2 years ago.
ezgif.com-video-to-gif.gif (93.4 KB) - added by ronakganatra 2 years ago.
ezgif.com-optimize.gif (126.6 KB) - added by ronakganatra 2 years ago.

Download all attachments as: .zip

Change History (9)

#1 @SergeyBiryukov
2 years ago

  • Component changed from General to Login and Registration
  • Focuses accessibility added

Thanks for the patch!

I don't think we can just remove the focus styles for this button, that would make it less accessible.

#2 @afercia
2 years ago

  • Keywords close added

@ronakganatra thanks for your feedback.

When clicking the Show Password button, focus is moved to the password input field. When the input field gets focused, it shows the focus style that all the input fields in WordPress use. Indication of focus is essential for accessibility, as many users (keyboard users, users with low vision, etc.) need to see where focus is to be able to operate on the user interface.

It's worth re-evaluating if moving focus is really necessary in the first place, as that could help some users but it could be potentially confusing for other users. However, the focus style can't be removed :)

#3 @ronakganatra
2 years ago

Thanks @afercia , Sounds perfect and agree with you.

Thanks for your reply and reviewing this ticket.

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.

2 years ago

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.

2 years ago

#6 @afercia
2 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from assigned to closed

This ticket was discussed during today's accessibility bug-scrub: agreed to close. Thanks for the report and participation.

Note: See TracTickets for help on using tickets.