WordPress.org

Make WordPress Core

Opened 14 months ago

Last modified 8 weeks ago

#48782 new defect (bug)

Fix link-manager styles

Reported by: antonlukin Owned by:
Milestone: 5.7 Priority: normal
Severity: minor Version: 5.3
Component: Posts, Post Types Keywords: has-screenshots good-first-bug has-patch
Focuses: ui, css Cc:

Description

Link Manager lacks the required form styles. Need to add some padding to .inside element.

Attachments (2)

link-manager.png (158.1 KB) - added by antonlukin 14 months ago.
Link-manager styles bug
48782-patch-applied.png (14.7 KB) - added by pbiron 2 months ago.
with the PR applied

Download all attachments as: .zip

Change History (12)

@antonlukin
14 months ago

Link-manager styles bug

#1 @SergeyBiryukov
14 months ago

Hi there, welcome to WordPress Trac! Thanks for the ticket.

For some context, Link Manager is deprecated in core since WordPress 3.5:

  • #21307 hides it in the UI for newer installs and requires the Link Manager plugin to re-enable.
  • #22994 removes it from import options.
  • #42131 proposes to remove it completely, though closed as maybelater for now.

That said, I have no objections to fixing the padding if it doesn't require too much effort.

This ticket was mentioned in Slack in #core-css by ryelle. View the logs.


4 months ago

This ticket was mentioned in Slack in #core-css by kirstyburgoine. View the logs.


4 months ago

#4 @kburgoine
4 months ago

  • Keywords needs-patch good-first-bug added
  • Milestone changed from Awaiting Review to Future Release

This ticket was mentioned in PR #753 on WordPress/wordpress-develop by grzim.


2 months ago

  • Keywords has-patch added; needs-patch removed

add margins to inputs as described in 48782.
add a border-bottom to headers to make all headers consistent.

In order to access Links, please download the plugin from https://wordpress.org/plugins/link-manager/ and upload it from your computer.

Trac ticket: https://core.trac.wordpress.org/ticket/48782

#6 @prbot
2 months ago

github-actions[bot] commented on PR #753:

Hi @grzim! 👋

Thank you for your contribution to WordPress! 💖

It looks like this is your first pull request to wordpress-develop. Here are a few things to be aware of that may help you out!

No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description.

Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making.

More information about how GitHub pull requests can be used to contribute to WordPress can be found in this blog post.

Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook.

If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook.

The Developer Hub also documents the various coding standards that are followed:

Thank you,
The WordPress Project

This ticket was mentioned in Slack in #meta by timothybjacobs. View the logs.


2 months ago

@pbiron
2 months ago

with the PR applied

#9 @pbiron
2 months ago

I still have a few sites that use Link Manager and the PR LGTM, so I'd say this should be fixed...since the reason it currently looks the way it does is because of other WP admin CSS changes since Link Manager was depreciated. The changes in the PR are confined to the Links screen(s), so I don't think there is any downside.

Last edited 2 months ago by pbiron (previous) (diff)

#10 @sabernhardt
8 weeks ago

  • Milestone changed from Future Release to 5.7

Thanks for the PR @grzim! The styles look good on the Add New Link page, but the .inside top margin is still only 6 pixels on the Edit Link page instead of 12.

Here are a few suggestions:

  1. Include .link-php #poststuff .inside for the override (or else add a new class to the first div within the form element on both pages).
  2. Move this style override after #poststuff .inside.
  3. Only specify the top margin for the .link-php and .link-add-php styles.
  4. Simplify the existing shorthand for #poststuff .inside.
#poststuff .inside {
	margin: 6px 0 0;
}

.link-php #poststuff .inside,
.link-add-php #poststuff .inside {
	margin-top: 12px;
}
Note: See TracTickets for help on using tickets.